Implement event duplication feature and improve registration error handling#407
Open
Ethan-Stone1 wants to merge 23 commits intosnap-cloud:mainfrom
Open
Implement event duplication feature and improve registration error handling#407Ethan-Stone1 wants to merge 23 commits intosnap-cloud:mainfrom
Ethan-Stone1 wants to merge 23 commits intosnap-cloud:mainfrom
Conversation
The sign-up form silently fails when validation errors occur (e.g., duplicate username, password too short, password mismatch) because the Devise registration views never render resource.errors. Add error message rendering to the _form_fields partial so users see clear feedback when registration fails. Fixes #61
Fix registration form not displaying validation errors
Implement a new feature (Issue #54) to duplicate events within a conference
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements Issue cs169#54 to allow for the duplication of events. Additionally implements a small fix to registration form not displaying validation errors
Event Duplication:
On the event page there is now a "Duplicate" button
Pressing the button opens a popup where you can select how many different duplicates of the event you would like
The duplicated events have all the same data as the original (minus the ID and the creator is the person who clicked duplicate)
How should this PR be tested?
There are a ton of tests (in fact most of the lines of code I added are tests. To run them type
bundle exec rspec spec/features/event_duplication_spec.rb spec/controllers/admin/events_controller_spec.rb
in the terminal.
Are there any complications to deploying this?
No data migrations or anything complicated about deploying.