Skip to content

NO-SNOW: Fix UDF parameter registration error #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sfc-gh-joshi wants to merge 3 commits into
base: main
Choose a base branch
from
Open

NO-SNOW: Fix UDF parameter registration error #4064

sfc-gh-joshi wants to merge 3 commits into from
+39 −6

Conversation

@sfc-gh-joshi
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi commented Jan 29, 2026 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

Fixes a very minor bug where positional parameters are not passed correctly during UDF registration through register_from_file, causing strict and secure to improperly be set. This was exposed while testing a pre-release version of protobuf for #4056, but that fix is no longer needed since protobuf released a compatible patch release that requires no action on our part.

@sfc-gh-joshi sfc-gh-joshi added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jan 29, 2026
@sfc-gh-joshi sfc-gh-joshi requested review from a team as code owners January 29, 2026 23:34
@sfc-gh-joshi sfc-gh-joshi added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Jan 29, 2026
@sfc-gh-joshi
fix UDF call error and bump protobuf
a06b8e8 
changelog

revert ceiling change, fix udf error

add missing max_batch_size arg
@sfc-gh-joshi
revert max_batch_size param
e227828
@sfc-gh-joshi
changelog
cacf5a0
@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi-SNOW-3018722-protobuf-bump branch from 9759bcd to cacf5a0 Compare February 10, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mayliu sfc-gh-mayliu sfc-gh-mayliu approved these changes

@sfc-gh-bkogan sfc-gh-bkogan sfc-gh-bkogan approved these changes

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-joshi @sfc-gh-mayliu @sfc-gh-bkogan