Update expected output in getting started guide for Ruby 3.4+ - #207
Open
yukik8 wants to merge 1 commit into
Open
Update expected output in getting started guide for Ruby 3.4+#207yukik8 wants to merge 1 commit into
yukik8 wants to merge 1 commit into
Conversation
Signed-off-by: yukik8 <andres8.yuuki@gmail.com>
2 tasks
Member
|
Could you please rebase :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Basic Event Loop" example in the getting started guide shows the expected output as
{:read=>"Hello World"}. Since Ruby 3.4,Hash#inspectuses a new format (see Feature #16295), so running the example as-is on current Ruby versions actually prints:This updates the expected output to match what readers will see on Ruby 3.4+. On Ruby 3.3 (which this gem still supports) the old format is shown — happy to add a note mentioning that if you prefer.
Verified by running the example unchanged on Ruby 3.4.10 (macOS arm64).
Types of Changes
Contribution