Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/protocol/url.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2025, by Samuel Williams.

require_relative "url/version"
require_relative "url/error"
require_relative "url/pattern"
require_relative "url/encoding"
require_relative "url/form_data/nested"
Expand Down
12 changes: 12 additions & 0 deletions lib/protocol/url/error.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# frozen_string_literal: true

# Released under the MIT License.
# Copyright, 2026, by Samuel Williams.

module Protocol
module URL
# Raised when URL processing exceeds a configured limit.
class LimitError < StandardError
end
end
end
3 changes: 2 additions & 1 deletion lib/protocol/url/form_data/nested.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2026, by Samuel Williams.

require_relative "../encoding"
require_relative "../error"

module Protocol
module URL
Expand Down Expand Up @@ -32,7 +33,7 @@ def add(name, value)
end

if @depth_limit and keys.size > @depth_limit
raise RangeError, "Form data depth exceeded limit of #{@depth_limit}!"
raise LimitError, "Form data depth exceeded limit of #{@depth_limit}!"
end

Encoding.assign(keys, value, @root)
Expand Down
3 changes: 2 additions & 1 deletion lib/protocol/url/form_data/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
# Copyright, 2026, by Samuel Williams.

require_relative "nested"
require_relative "../error"

module Protocol
module URL
Expand Down Expand Up @@ -107,7 +108,7 @@ def decode_component(component)

def check_limit(name, value, limit)
if limit and value > limit
raise RangeError, "Form data #{name} exceeded limit of #{limit}!"
raise LimitError, "Form data #{name} exceeded limit of #{limit}!"
end
end
end
Expand Down
4 changes: 4 additions & 0 deletions releases.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Releases

## Unreleased

- Add `Protocol::URL::LimitError` for configured processing limits.

## v0.8.0

- Use consistent limit naming for form data parser constraints.
Expand Down
2 changes: 1 addition & 1 deletion test/protocol/url/form_data/nested.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

expect do
nested.add("a[b][c]", "value")
end.to raise_exception(RangeError, message: be =~ /depth exceeded/)
end.to raise_exception(Protocol::URL::LimitError, message: be =~ /depth exceeded/)
end

it "allows the nesting limit to be disabled" do
Expand Down
6 changes: 3 additions & 3 deletions test/protocol/url/form_data/parser.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def to_h

expect do
parser.parse(StringIO.new("a=123"))
end.to raise_exception(RangeError, message: be =~ /size exceeded limit of 4/)
end.to raise_exception(Protocol::URL::LimitError, message: be =~ /size exceeded limit of 4/)
end

it "applies the pair count limit at its boundary" do
Expand All @@ -92,7 +92,7 @@ def to_h

expect do
parser.parse(StringIO.new("a=1&b=2&c=3"))
end.to raise_exception(RangeError, message: be =~ /pair_count exceeded limit of 2/)
end.to raise_exception(Protocol::URL::LimitError, message: be =~ /pair_count exceeded limit of 2/)
end

it "allows limits to be disabled" do
Expand All @@ -109,7 +109,7 @@ def to_h

expect do
parser.parse(StringIO.new("a%5Bb%5D%5Bc%5D=1"))
end.to raise_exception(RangeError, message: be =~ /depth exceeded limit of 2/)
end.to raise_exception(Protocol::URL::LimitError, message: be =~ /depth exceeded limit of 2/)
end

it "rejects an empty name when building nested form data" do
Expand Down
Loading