Skip to content

feat(home): 홈 푸터에 사업자 정보 추가#498

Merged
wibaek merged 2 commits intomainfrom
feature/copyright
Apr 16, 2026
Merged

feat(home): 홈 푸터에 사업자 정보 추가#498
wibaek merged 2 commits intomainfrom
feature/copyright

Conversation

@wibaekpark
Copy link
Copy Markdown
Contributor

Summary

  • 홈 화면 하단에 사업자 정보를 노출하는 SiteFooter 컴포넌트를 추가했습니다.
  • 사용자에게 상호, 대표자, 사업자등록번호, 주소, 저작권 정보를 한곳에서 확인할 수 있도록 구성했습니다.

변경 사항

  • apps/web/src/app/(home)/_ui/SiteFooter/index.tsx 추가
  • 홈 페이지 하단에 SiteFooter를 렌더링하도록 연결
  • 현재 연도를 기준으로 저작권 문구가 표시되도록 구현

Testing

  • Not run (not requested)

노트

  • 푸터는 홈 화면에만 적용됩니다.

@vercel vercel Bot temporarily deployed to Preview – solid-connect-web-admin April 15, 2026 14:34 Inactive
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connection-web Ready Ready Preview, Comment Apr 15, 2026 2:51pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Apr 15, 2026 2:51pm

@github-actions github-actions Bot added the web label Apr 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 15, 2026

Warning

Rate limit exceeded

@wibaekpark has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 44 minutes and 42 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 44 minutes and 42 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3034fae1-3cc4-4f4a-838c-212abc544e16

📥 Commits

Reviewing files that changed from the base of the PR and between 62fd27a and adf63ea.

📒 Files selected for processing (1)
  • apps/web/src/app/(home)/_ui/SiteFooter/index.tsx

Walkthrough

새로운 SiteFooter React 컴포넌트를 추가하고 홈페이지 하단에 통합했습니다. 푸터는 사업자 정보 제목, 매핑된 비즈니스 정보 항목 목록, 현재 연도가 포함된 저작권 표기를 렌더링합니다.

변경사항 정리:

  1. SiteFooter 컴포넌트 신규 생성 (Tailwind 유틸리티 클래스 스타일 적용)
  2. 홈페이지에서 SiteFooter 임포트 및 뉴스 섹션 하단에 렌더링

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 분

Suggested reviewers

  • wibaek
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 핵심을 명확하게 요약하고 있습니다. '홈 푸터에 사업자 정보 추가'는 이 PR의 주요 변경 내용을 정확히 반영합니다.
Description check ✅ Passed PR 설명이 필요한 섹션들을 포함하고 있으나, '관련 이슈' 섹션이 누락되어 있습니다. 나머지 작업 내용, 변경 사항, 테스팅, 노트 등은 충실하게 작성되었습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/copyright

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/web/src/app/(home)/_ui/SiteFooter/index.tsx (1)

11-20: 2) 시맨틱 태그를 쓰면 접근성과 문서 구조가 더 또렷해집니다

지금도 렌더링은 잘 되지만, 제목은 <h2>, 사업자 정보 묶음은 <address>를 쓰면 스크린리더/SEO 관점에서 의미 전달이 더 좋아집니다.

리팩터 예시
-      <p className="mb-2 font-serif text-k-600 typo-sb-11">사업자 정보</p>
-      <ul className="space-y-1">
-        {BUSINESS_INFO.map(({ label, value }) => (
-          <li key={label} className="flex gap-2 text-k-500 typo-regular-5">
-            <span className="w-20 shrink-0 text-k-400">{label}</span>
-            <span className="flex-1 text-k-600">{value}</span>
-          </li>
-        ))}
-      </ul>
+      <h2 className="mb-2 font-serif text-k-600 typo-sb-11">사업자 정보</h2>
+      <address className="not-italic">
+        <ul className="space-y-1">
+          {BUSINESS_INFO.map(({ label, value }) => (
+            <li key={label} className="flex gap-2 text-k-500 typo-regular-5">
+              <span className="w-20 shrink-0 text-k-400">{label}</span>
+              <span className="flex-1 text-k-600">{value}</span>
+            </li>
+          ))}
+        </ul>
+      </address>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/app/`(home)/_ui/SiteFooter/index.tsx around lines 11 - 20, Wrap
the business information block in a semantic container and use a heading:
replace the decorative <p> title with an <h2> (keeping the existing className
for styling) and wrap the BUSINESS_INFO list and its items in an <address>
element (preserving the <ul> and <li> structure and classNames) so screen
readers and SEO can interpret it as contact/ownership information; ensure the
copyright line remains semantically separate (e.g., keep it as a paragraph) and
that no visual styles change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/web/src/app/`(home)/_ui/SiteFooter/index.tsx:
- Line 3: Update the footer data entry where the label is "대표" in the SiteFooter
component to use the legal term "대표자"; locate the object literal inside the
list/array in SiteFooter/index.tsx (the entry with { label: "대표", value: "박위백"
}) and change the label string to "대표자" so the displayed/legal wording matches
PR and documentation.

---

Nitpick comments:
In `@apps/web/src/app/`(home)/_ui/SiteFooter/index.tsx:
- Around line 11-20: Wrap the business information block in a semantic container
and use a heading: replace the decorative <p> title with an <h2> (keeping the
existing className for styling) and wrap the BUSINESS_INFO list and its items in
an <address> element (preserving the <ul> and <li> structure and classNames) so
screen readers and SEO can interpret it as contact/ownership information; ensure
the copyright line remains semantically separate (e.g., keep it as a paragraph)
and that no visual styles change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f0d8bfa1-31f1-408d-a12b-083cd63daefd

📥 Commits

Reviewing files that changed from the base of the PR and between bdb97a3 and 62fd27a.

📒 Files selected for processing (2)
  • apps/web/src/app/(home)/_ui/SiteFooter/index.tsx
  • apps/web/src/app/(home)/page.tsx

Comment thread apps/web/src/app/(home)/_ui/SiteFooter/index.tsx Outdated
@wibaek wibaek self-assigned this Apr 15, 2026
@vercel vercel Bot temporarily deployed to Preview – solid-connect-web-admin April 15, 2026 14:49 Inactive
@wibaek wibaek merged commit dae3441 into main Apr 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants