Fix: Resolve glob expansion issue in build script on Windows#836
Open
JavanPoirier wants to merge 1 commit intosolidjs-community:mainfrom
Open
Fix: Resolve glob expansion issue in build script on Windows#836JavanPoirier wants to merge 1 commit intosolidjs-community:mainfrom
JavanPoirier wants to merge 1 commit intosolidjs-community:mainfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Resolve glob expansion issue in build script on Windows
Problem
The build script was failing on Windows with Git Bash (MINGW64) with the error:
error TS5083: Cannot read file 'D:/Repos/solid-primitives/packages/*/tsconfig.json'.Root Cause
The
tsc -b packages/*command relied on shell glob expansion to pass all package directories to TypeScript. However, when usingshell: truewithchild_process.spawn()on Windows, the glob patternpackages/*was not being expanded and was passed literally to TypeScript, which tried to read a file path containing an asterisk.Solution
Modified the build script to explicitly read and expand the packages directory before spawning the TypeScript compiler:
fs.readdir().)packages/{name})tsccommand argumentsThis ensures the command receives actual paths like
tsc -b packages/active-element packages/analytics ...instead of relying on shell glob expansion.Benefits
Testing
Verified that
pnpm generatenow completes successfully on Windows.