enhancement: add class to VirtualList#972
Conversation
🦋 Changeset detectedLatest commit: 81db4ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Added an optional
classprop to<VirtualList>, applied to the internal wrapper that holds the rendered rows. This lets consumers lay out rows with flexbox/grid (e.g.display: flex; flex-flow: column; width: 100%;) instead of styling each row individually — resolves #698.packages/virtual/dev/demo folder.class") demonstrating the new prop with a flex-column row layout and uniform gaps.classprop, and fixed a pre-existing example bug wherecreateVirtualList's<For>usage calleditem()withoutkeyed={false}— added an explanation that<For>defaults tokeyed={true}(raw values) and needskeyed={false}to receive items asAccessors.classis applied to the row wrapper, and updated the SSR snapshot test (class={undefined}still serializes asclass=""under@solidjs/web's SSR renderer).Summary by CodeRabbit
New Features
<VirtualList>now supports aclassprop, making it easier to style the rows wrapper.Documentation
visibleItemsshould be rendered.Bug Fixes
Tests