-
Notifications
You must be signed in to change notification settings - Fork 154
Add ContextConsumer (V2)
#974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FabianHummel
wants to merge
16
commits into
solidjs-community:next
Choose a base branch
from
FabianHummel:context-consume-v2
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d2e3c60
Added context consumer
FabianHummel 7425c71
Added raw context prop
FabianHummel d612791
Merge branch 'main' into context-consume
FabianHummel 55916fb
context: Add changeset
thetarnav ce9e9b6
Merged useFn and context
FabianHummel e71e4ad
Merge branch 'main' into context-consume
FabianHummel 43185e3
Merge remote-tracking branch 'fabianhummel/context-consume' into cont…
FabianHummel d000356
Migration to v2
FabianHummel 0db07e8
Adjustments to Unit Tests and README.md
FabianHummel 69ad8c4
Fix documentation for context consumer component
FabianHummel dd43194
Revert remove changeset
FabianHummel 45f915a
Merge remote-tracking branch 'fabianhummel/context-consume-v2' into c…
FabianHummel 4d65bc0
Merge branch 'next' into context-consume-v2
davedbase 1b02d3d
Merge branch 'next' into context-consume-v2
davedbase edffd61
Added fallback prop and Unit Tests
FabianHummel 15c070e
Updated documentation regarding fallback values.
FabianHummel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@solid-primitives/context": minor | ||
| --- | ||
|
|
||
| Add `ContextConsumer` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fallback doesn't suppress
ContextNotFoundError, and no-fallback path silently returnsundefinedinstead of throwing.Two gaps versus the documented contract ("if no fallback is provided, this component will throw an error"):
useContextthrows synchronously before thisundefinedcheck runs, sofallbackcan never mask that error.fallbacksupplied, this returnsundefinedsilently rather than throwing.Please document limitation (1) in the README so users don't expect
fallbackto suppress errors for required contexts, and consider whether (2) should throw explicitly to match the documented behavior.🤖 Prompt for AI Agents