Skip to content

fix: Highlight active version in version selector dropdown#1572

Merged
LadyBluenotes merged 3 commits into
solidjs:mainfrom
tknkaa:fix/version-selector-highlight
Jul 6, 2026
Merged

fix: Highlight active version in version selector dropdown#1572
LadyBluenotes merged 3 commits into
solidjs:mainfrom
tknkaa:fix/version-selector-highlight

Conversation

@tknkaa

@tknkaa tknkaa commented Jul 5, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

The version selector dropdown was auto-focusing the first item ("Latest") when opened, giving it a focus background — making it appear selected regardless of the current version. Meanwhile, the aria-current attribute on the actual active item had no visual styling applied.

This fix:

  • Changes focus: to focus-visible: on dropdown items so programmatic/auto-focus no longer triggers the background highlight
  • Adds aria-[current]:bg-blue-50 / dark:aria-[current]:bg-blue-900/30 to visually highlight the active version

Related issues & labels

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify

netlify Bot commented Jul 5, 2026

Copy link
Copy Markdown

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 42da6b4
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6a4afc8884e3a90008d13231
😎 Deploy Preview https://deploy-preview-1572--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@LadyBluenotes

Copy link
Copy Markdown
Member

@tknkaa Thank you for your PR working on this. Can you please add back in the PR template and indicate whether you've read the contributing guidelines?

@LadyBluenotes LadyBluenotes merged commit 0dad330 into solidjs:main Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Version selector dropdown highlights Latest instead of the current version

2 participants