[patch]: Allow user to set metric on default route learned via Router Advertisement.#180
Open
praveen-li wants to merge 2 commits intosonic-net:masterfrom
Open
[patch]: Allow user to set metric on default route learned via Router Advertisement.#180praveen-li wants to merge 2 commits intosonic-net:masterfrom
praveen-li wants to merge 2 commits intosonic-net:masterfrom
Conversation
385ad2d to
ca7ea87
Compare
|
@praveen-li , you can create it as a "draft" PR :) |
Member
Author
@prsunny, Yeah, For next time, I will remember abt draft PRs :) |
Contributor
|
you can convert to draft pr. |
Member
Author
Okies, did it. Thx. |
1104a15 to
c102a6b
Compare
Contributor
|
is this back port fix? |
Member
Author
We will raise it with the Linux kernel community, if they merge, we will backport till 4.9. Yeah this patch is applicable only till 4.9. |
paulmenzel
suggested changes
Dec 31, 2020
Contributor
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you for the patch.
- Please follow the Linux kernel coding style.
- Please develop against Linux master, and submit the patch upstream as early as possible – even as RFC (request for comments) – so the Linux network developers can review the idea as early as possible.
- Please extend the commit messages, and even give an explanation, why this feature is a good idea, and add performance numbers without and with this feature enabled.
e24b267 to
a3bcfed
Compare
Signed-off-by: Praveen Chaudhary<[email protected]>
a3bcfed to
b714e69
Compare
4a5af9d to
f43d588
Compare
Contributor
|
can you add commit message in the patch? |
|
/easycla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is merged in Linux 5.12, we can keep it as patch till we reach Linux 5.12.
torvalds/linux@6b2e04b
Allow user to set metric on default route learned via Router Advertisement.
Note: RFC 4191 does not say anything for metric for IPv6 default route.
Fix:
For IPv4, default route is learned via DHCPv4 and user is allowed to change
metric using config in etc/network/interfaces. But for IPv6, default route can
be learned via RA, for which, currently a fixed metric value 1024 is used.
Ideally, user should be able to configure metric on default route for IPv6
similar to IPv4. This fix adds sysctl for the same.
Logs:
For IPv4:
Config in etc/network/interfaces
IPv4 Kernel Route Table:
FRR Table, if default route is learned via routing protocol too.
i.e. User can prefer Default Router learned via Routing Protocol,
Similar behavior is not possible for IPv6, without this fix.
After fix [for IPv6]:
IP monitor:
Kernel IPv6 routing table
FRR Routing Table, if default route is learned via routing protocol.