feat(billing): add billing endpoints by Sourav-kashyap · Pull Request #121 · sourcefuse/arc-saas

Sourav-kashyap · 2026-05-19T15:27:59Z

Description

This PR adds three new billing endpoints to retrieve detailed payment and invoice information, along with TypeScript type improvements for webhook handling. The new endpoints provide essential functionality for invoice management and payment tracking in SaaS subscription workflows.

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

Performed a self-review of my own code
npm test passes on your machine

yeshamavani · 2026-05-20T10:25:39Z

+  process.env.FEATURE_DB_HOST = 'localhost';
+  process.env.FEATURE_DB_PORT = '5432';
+  process.env.FEATURE_DB_USER = 'test';
+  process.env.FEATURE_DB_PASSWORD = 'test';
+  process.env.FEATURE_DB_DATABASE = 'test';
+  process.env.FEATURE_DB_SCHEMA = 'public';
+  // Billing config
+  process.env.SITE = 'test';
+  process.env.API_KEY = 'test';
+  process.env.STRIPE_SECRET = 'test';


why a database setup, cant we use memory store here ?

yeshamavani · 2026-05-20T10:26:11Z

+  @post(`${BASE}/customers`, {
+    summary: 'Create a new customer',
+    responses: {
+      '200': {


magic number

yeshamavani · 2026-05-20T10:26:22Z

+          schema: {
+            type: 'object',
+            required: ['firstName', 'lastName', 'email'],
+            properties: {
+              firstName: {type: 'string', example: 'John'},
+              lastName: {type: 'string', example: 'Doe'},
+              email: {type: 'string', example: 'john.doe@example.com'},
+              company: {type: 'string', example: 'Acme Inc.'},
+              phone: {type: 'string', example: '+1234567890'},
+              billingAddress: {
+                type: 'object',
+                properties: {
+                  line1: {type: 'string'},
+                  city: {type: 'string'},
+                  state: {type: 'string'},
+                  zip: {type: 'string'},
+                  country: {type: 'string', example: 'US'},


yeshamavani · 2026-05-20T10:26:46Z

+        'application/json': {
+          schema: {
+            type: 'object',
+            properties: {
+              firstName: {type: 'string'},
+              lastName: {type: 'string'},
+              email: {type: 'string'},
+              company: {type: 'string'},
+              phone: {type: 'string'},
+              billingAddress: {
+                type: 'object',
+                properties: {
+                  line1: {type: 'string'},
+                  city: {type: 'string'},
+                  state: {type: 'string'},
+                  zip: {type: 'string'},
+                  country: {type: 'string'},
+                },
+              },
+            },
+          },
+        },
+      },


define type

yeshamavani · 2026-05-20T10:27:55Z

+    this.application.bind(StripeBindings.config).to({
+      secretKey: process.env.STRIPE_SECRET ?? '',
+    });
+    this.application
+      .bind(BillingComponentBindings.SDKProvider)
+      .toProvider(StripeServiceProvider);
+


this will be in sandbox

yeshamavani · 2026-05-20T10:28:22Z

    // Mount authorization component for default sequence
    this.application.bind(AuthorizationBindings.CONFIG).to({
-      allowAlwaysPaths: ['/explorer'],
+      allowAlwaysPaths: ['/explorer', '/billing', '/webhooks'],


there was a webhook component right ?

why is it not added there then ?

yeshamavani · 2026-05-20T10:28:50Z

+SITE=
+API_KEY=
+STRIPE_SECRET=
+CHARGEBEE_ITEM_FAMILY_ID=
+BILLING_PROVIDER=


no all this will b ein sandbox

Tyagi-Sunny · 2026-05-21T10:31:01Z

+    },
+  })
+  async createCustomer(
+    @requestBody({


does this create the customer on stripe? if yes, then we alreayd has the apis to create the customer. what is the difference between them

Tyagi-Sunny · 2026-05-21T10:32:12Z

+    },
+  })
+  async getCustomer(
+    @param.path.string('customerId') customerId: string,


these endpoints already exist exist , review pls

Tyagi-Sunny · 2026-05-21T10:32:54Z

+      },
+    })
+    paymentDto: BillingPaymentSourceBody,
+  ): Promise<TPaymentSource> {


we already have the api , then why need to create new

Tyagi-Sunny · 2026-05-21T10:34:02Z

+                  },
+                },
+              },
+            },


keep them seprate , for product , price, keep them separate

Tyagi-Sunny · 2026-05-21T10:34:59Z

+ * interceptor to BILLING_WEBHOOK_VERIFIER in application.ts.
+ */
+export class BillingWebhookController {
+  constructor(


we already had a controller for ir

sonarqubecloud · 2026-06-24T05:46:46Z

SonarQube reviewer guide

Summary: Add billing service controllers and update configuration for invoice management and subscription operations.

Review Focus:

The changes introduce extensive billing service integration with new controllers for invoicing, subscriptions, and payment handling
Verify that all authorization checks use correct PermissionKey values
Check that the allowAlwaysPaths in component.ts properly exposes /billing and /webhooks endpoints without auth barriers while maintaining security elsewhere
Ensure new DTO models align with loopback4-billing package type definitions

Start review at: services/subscription-service/src/component.ts. This file configures the allowAlwaysPaths authorization whitelist, which directly controls which billing endpoints bypass authentication - a critical security boundary. Confirm that /billing exposure is intentional and that sensitive operations like payment processing still have proper downstream authentication checks.

💬 Please send your feedback

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sourav-kashyap requested review from a-ganguly and yeshamavani May 19, 2026 15:27

Sourav-kashyap self-assigned this May 19, 2026

Sourav-kashyap linked an issue May 19, 2026 that may be closed by this pull request

add billing subscription features #120

Open

Sourav-kashyap force-pushed the GH-120 branch 4 times, most recently from 2fe29d0 to 6baedad Compare May 20, 2026 10:21

yeshamavani requested changes May 20, 2026

View reviewed changes

Sourav-kashyap force-pushed the GH-120 branch 2 times, most recently from 1841efc to 5673f13 Compare May 20, 2026 13:38

Sourav-kashyap requested a review from yeshamavani May 21, 2026 04:37

Tyagi-Sunny reviewed May 21, 2026

View reviewed changes

Sourav-kashyap force-pushed the GH-120 branch from c58fe44 to 9a123de Compare May 22, 2026 07:44

Sourav-kashyap requested a review from Tyagi-Sunny May 22, 2026 07:47

Sourav-kashyap force-pushed the GH-120 branch from 5a901d7 to 9285d61 Compare May 26, 2026 09:40

Sourav-kashyap added 5 commits June 24, 2026 10:46

feat(billing): add billing endpoints

7d5e5f4

feat(billing): fix sonar issue

03197e9

feat(billing): fix sonar

f233618

feat(billing): fix comments

c799ae8

feat(billing): fix comments

7fab627

Sourav-kashyap force-pushed the GH-120 branch 5 times, most recently from cd672ac to 8d49ba4 Compare June 24, 2026 05:42

feat(billing): align codebase with existing project structure

a34aeb4

Sourav-kashyap force-pushed the GH-120 branch from 8d49ba4 to a34aeb4 Compare June 24, 2026 05:45

Uh oh!

Conversation

Sourav-kashyap commented May 19, 2026

Description

Type of change

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sourav-kashyap May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jun 24, 2026

SonarQube reviewer guide

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sourav-kashyap May 20, 2026 •

edited

Loading