feat(cache): add sequelize support#2554
Open
Sourav-kashyap wants to merge 2 commits into
Open
Conversation
Sourav-kashyap
force-pushed
the
GH-2552
branch
6 times, most recently
from
eee3c4b to
4148390
Compare
rashisf
reviewed
Jun 22, 2026
| this.bind(HelmetSecurityBindings.CONFIG).to({ | ||
| frameguard: {action: process.env.X_FRAME_OPTIONS}, | ||
| frameguard: { | ||
| action: process.env.X_FRAME_OPTIONS as |
Contributor
There was a problem hiding this comment.
is this part of the cache support that you added
Contributor
Author
There was a problem hiding this comment.
no this changes wasn't part of the cache support. this changes for TypeScript/ESLint type-safety issue where process.env.X_FRAME_OPTIONS is typed as string | undefined, but frameguard.action expects 'deny' | 'sameorigin' | undefined.
rashisf
approved these changes
Jun 22, 2026
add sequelize support GH-2552
SonarQube reviewer guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-2552
Description
Added Sequelize support to the cache package
Type of change
Checklist: