-
Notifications
You must be signed in to change notification settings - Fork 86
Redirect /technical-changelog.rss to new docs service #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove local RSS generation (dev/rss.js) - Redirect to https://sourcegraph.com/changelog/technical-changelog.rss - Extract URL to shared constant
6bd9e69 to
8cf86b6
Compare
7c424bd to
136d495
Compare
src/middleware.ts
Outdated
| return NextResponse.redirect( | ||
| createRedirectUrl(request, redirect.destination, path) | ||
| createRedirectUrl(request, redirect.destination, path), | ||
| redirect.permanent ? 308 : 307 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permanent redirects are basically impossible to ever change again because of very aggressive browser caching, maybe we should just keep them as 307s? there are a lot of permanent ones in the redirects and I'm not convinced we want all of them to redirect for all time going forward 😬
eseliger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve to unblock, left 1 suggestion
|
Verified it works in prod curl -I https://sourcegraph.com/docs/technical-changelog.rss
HTTP/2 307
location: https://sourcegraph.com/changelog/technical-changelog.rss |
RSS feed is now served from the new docs service at
/changelog/technical-changelog.rss.dev/rss.js)Test plan