Merged
Conversation
At Sourcegraph we do a sparse clone which excludes files based on max file size. However, cat-file will hydrate in missing objects. So we pass in the same filter to avoid hydrating in those files.
Member
Author
|
cc @clemlesne |
Member
Author
|
Also I see why in the original version of #1021 it treated missing as skipped large files. That is what we did in go-git since that matched up the behaviour we expect when sourcegraph shallow clones a repo. Good to keep the "missing" status since that is more accurate. |
Contributor
|
Indeed that use case was completely missing from the integration tests. Would be useful to add it (like you use it internally?) to avoid future issues! |
Member
Author
|
This PR adds a test which asserts the behaviour around missing vs excluded in git cat-file when you do a sparse clone. |
stefanhengl
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At Sourcegraph we do a sparse clone which excludes files based on max file size. However, cat-file will hydrate in missing objects. So we pass in the same filter to avoid hydrating in those files while running zoekt-git-index.
See #1021