Skip to content

fix: remove unused dependencies from simple crates#183

Open
tlovell-sxt wants to merge 35 commits intomainfrom
fix/simple-unused-dependencies
Open

fix: remove unused dependencies from simple crates#183
tlovell-sxt wants to merge 35 commits intomainfrom
fix/simple-unused-dependencies

Conversation

@tlovell-sxt
Copy link
Copy Markdown
Contributor

Rationale for this change

Many crates in this repository declare dependencies that go unused in any of their packages/features. This change removes unused dependencies and configures crates to warn on unused dependencies for many of the crates in this repository.

However, this does not touch all the crates. In particular, crates that have more than one package (lib/bin, test binaries, example binaries) were skipped. Dealing warning on unused dependencies in those crates will be more complicated, and may encourage some structural changes going in first. This PR excludes:

  • native
  • pallet-commitments
  • watcher
  • event-forwarder
  • commitment-map

What changes are included in this PR?

The commits are a good summary of changes.

Are these changes tested?

These changes do not affect existing functionality, which should be verified by existing tests.

@tlovell-sxt tlovell-sxt force-pushed the fix/simple-unused-dependencies branch 2 times, most recently from 98c426b to 36aefb6 Compare April 2, 2026 17:10
@tlovell-sxt tlovell-sxt changed the base branch from fix/warnings to main April 2, 2026 17:11
@tlovell-sxt tlovell-sxt marked this pull request as ready for review April 2, 2026 17:11
@tlovell-sxt tlovell-sxt requested review from a team as code owners April 2, 2026 17:11
@tlovell-sxt tlovell-sxt force-pushed the fix/simple-unused-dependencies branch from 36aefb6 to 41f6b18 Compare April 22, 2026 16:53
@github-actions
Copy link
Copy Markdown

1.69.0

Bug Fixes

  • add basic documentation to runtime crate (30c26e7
  • add missing docs for runtime module items (52a2905
  • add missing docs to chain-utils (c8235c6
  • address warnings in on-chain-table (095a856
  • address warnings in pallet-rewards mock module (886bc36
  • allow deprecated CurrencyAdapter usage (cfe0517
  • allow missing docs in private items in test_end_row_limits binary (7700cd6
  • allow missing_docs_in_private_items on event forwarder contract (b2d6f8b
  • allow unused private_key variables in pallet-keystore benchmarks (c218f0d
  • declare anonymous lifetime in commitment-sql proptest helper (63b3fc0
  • declare anonymous lifetimes in canaries parse functions (f81e9de
  • document all items in watcher main module (2fe60db
  • document memory_commitment_map module in commitment-map (32a38e3
  • document missing items in canaries (72c5f33
  • document missing items in event-forwarder (5408075
  • document modules in chain-utils (3eb6545
  • document modules in rpc crate (19cf1af
  • don't hide elided lifetimes in backwards compatibility test case generator (4e6968e
  • don't import frame_benchmarking if runtime-benchmarks is disabled in node (32cfca3
  • expect AttestationInfo::block_number to be dead code in canaries (7753c44
  • expect some dead code in NewFullBase in node (fe06f5e
  • ignore unused error variable in watcher main module (d330fe5
  • ignore unused variable in attestation-tree test (ce8adf3
  • ignore unused variable in pallet-attestation benchmarks (b0ef4a7
  • implement benchmark configurations for runtime outside runtime api implementation (d1a3db8
  • only define migrations with runtime-benchmarks disabled (26e8804
  • privatize deposit_event in pallet-rewards (6c1caaf
  • privatize deposit_event in pallet-smartcontracts (fe43a19
  • privatize deposit_event in pallet-system-tables (8bf7c21
  • privatize deposit_event in pallet-tables (da951a5
  • privatize pallet-keystore deposit_event (e878e37
  • privatize pallet-permissions deposit_event (099a7ba
  • privatize system-contracts deposit_event (305dfc9
  • privatize zkpay deposit_event (9d5993c
  • propagate tui error in update_ui in watcher (fe943eb
  • remove dead code in chain-utils (0070600
  • remove dead code in node (6958ec6
  • remove unused block_number parameter from verify_attestations in watcher (6225426
  • remove unused block_number parameter from verify_signature in watcher (08f3bff
  • remove unused const in pallet-tables test (e7bf9f5
  • remove unused const in runtime test (c7e0add
  • remove unused dependencies from canaries crate (008eff0
  • remove unused dependencies from commitment-sql (ebfe976
  • remove unused dependencies from sxt-core (361f8a0
  • remove unused dependencies in pallet-attestation (329bc03
  • remove unused dependencies in pallet-indexing (a71e954
  • remove unused dependencies in pallet-keystore (a83631b
  • remove unused dependencies in pallet-rewards (4349179
  • remove unused dependencies in pallet-smartcontracts (156e955
  • remove unused dependencies in pallet-system-tables (60e79f6
  • remove unused dependencies in pallet-tables (56daacd
  • remove unused dependencies in sxt-node (ffc8893
  • remove unused destructure variables in verify_attestation in watcher (dc04d24
  • remove unused import in memory_commitment_map test (4c2300a
  • remove unused import in pallet-attestation benchmarks (5fa662e
  • remove unused import in pallet-commitments migrations (ecf6a05
  • remove unused imports and format imports in chain-utils (5cd269b
  • remove unused imports in attestation-tree (91f5d61
  • remove unused imports in node (1f4c7a8
  • remove unused imports in pallet-smartcontracts (b7fa723
  • remove unused imports in pallet-tables (a08ccfd
  • remove unused imports in runtime (614a1e3
  • remove unused imports in test_end_row_limits (0328143
  • remove unused imports in watcher (340d27b
  • remove unused substrate key path from watcher client (2bd4d02
  • remove unused workspace dependencies (41f6b18
  • switch hex to being a dev dependency in rpc crate (7b01208
  • warn on unused dependencies in arrow-ipc-no-std (49b529c
  • warn on unused dependencies in attestation-tree (3f44d51
  • warn on unused dependencies in canaries (40ac0c1
  • warn on unused dependencies in chain-utils (987a888
  • warn on unused dependencies in commitment-column-mapping (3a80c0c
  • warn on unused dependencies in commitment-sql (b73fd0d
  • warn on unused dependencies in eth-ecdsa (1756f3b
  • warn on unused dependencies in native-api (fad5102
  • warn on unused dependencies in on-chain-table (3314939
  • warn on unused dependencies in pallet-attestation (199dce4
  • warn on unused dependencies in pallet-indexing (1f2816c
  • warn on unused dependencies in pallet-keystore (ddb7b81
  • warn on unused dependencies in pallet-permissions (4378805
  • warn on unused dependencies in pallet-rewards (39c45af
  • warn on unused dependencies in pallet-smartcontracts (b532948
  • warn on unused dependencies in pallet-system-contracts (b75543b
  • warn on unused dependencies in pallet-system-tables (3b25937
  • warn on unused dependencies in pallet-tables (200650f
  • warn on unused dependencies in pallet-zkpay (bf7f40b
  • warn on unused dependencies in proot-of-sql-unversioned (490833d
  • warn on unused dependencies in static-setups (30dd5d7
  • warn on unused dependencies in sxt-node (e9bdd82
  • warn on unused dependencies in sxt-runtime (ebdb7c1
  • warn on unused dependencies in unchecked-deserialize (f3055c9
  • warn unused_crate_dependencies in sxt-core (62c85b7

Features

  • allow SCI namespace creation without special permissions (092ba68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant