fix: remove unused dependencies from simple crates#183
Open
tlovell-sxt wants to merge 35 commits intomainfrom
Open
fix: remove unused dependencies from simple crates#183tlovell-sxt wants to merge 35 commits intomainfrom
tlovell-sxt wants to merge 35 commits intomainfrom
Conversation
98c426b to
36aefb6
Compare
36aefb6 to
41f6b18
Compare
1.69.0Bug Fixes
Features
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Many crates in this repository declare dependencies that go unused in any of their packages/features. This change removes unused dependencies and configures crates to warn on unused dependencies for many of the crates in this repository.
However, this does not touch all the crates. In particular, crates that have more than one package (lib/bin, test binaries, example binaries) were skipped. Dealing warning on unused dependencies in those crates will be more complicated, and may encourage some structural changes going in first. This PR excludes:
What changes are included in this PR?
The commits are a good summary of changes.
Are these changes tested?
These changes do not affect existing functionality, which should be verified by existing tests.