feat(otel/logs): pipe emitting component through otel logs#3434
Merged
itowlson merged 1 commit intospinframework:mainfrom Mar 30, 2026
Merged
feat(otel/logs): pipe emitting component through otel logs#3434itowlson merged 1 commit intospinframework:mainfrom
itowlson merged 1 commit intospinframework:mainfrom
Conversation
This commit updates the OTEL logging implementation to pass the component ID, so consuming tools can display it. Signed-off-by: Radu Matei <radu@fermyon.com>
Member
Author
|
The test failure has nothing to do with these changes, so not sure how to address it in this PR. Is that a known flaky test? |
Collaborator
|
I don't recall seeing that one flake before, no. I've kicked off a re-run. |
fibonacci1729
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the OTEL logging implementation to pass the component ID, so consuming tools can display it.