Skip to content

SPL-299716: M1/app framework v1 app validation#1845

Open
jzywiecki wants to merge 7 commits intomvp/app-framework-v1-app-crdfrom
mvp/app-framework-v1-app-validation
Open

SPL-299716: M1/app framework v1 app validation#1845
jzywiecki wants to merge 7 commits intomvp/app-framework-v1-app-crdfrom
mvp/app-framework-v1-app-validation

Conversation

@jzywiecki
Copy link
Copy Markdown

@jzywiecki jzywiecki commented Apr 14, 2026

Description

This MR adds validation for App resources to ensure:

  • the referenced app source exists before reconciliation proceeds
  • duplicate app definitions are rejected so each app remains unique

Key Changes

  • Added validation to verify that the referenced AppSource exists
  • Added validation to ensure an App is unique
  • Added tests covering the new validation behavior

Testing and Verification

  • Ran tests locally
  • Verified the new validation scenarios works

Alignments with immutability:

  • Immutability: scope, spec.appID, spec.targetRef are immutable
image

Uniqueness: only one App may exist per (targetRef, AppID, scope) and App Source reference

image

Related Issues

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
Signed-off-by: jzywieck <jzywiecki@splunk.com>
@jzywiecki jzywiecki marked this pull request as ready for review April 15, 2026 13:46
@jzywiecki jzywiecki changed the title Mvp/app framework v1 app validation M1/app framework v1 app validation Apr 15, 2026
@jzywiecki jzywiecki changed the title M1/app framework v1 app validation SPL-299716: M1/app framework v1 app validation Apr 15, 2026
@jzywiecki jzywiecki self-assigned this Apr 15, 2026
@jzywiecki jzywiecki force-pushed the mvp/app-framework-v1-app-crd branch from b80ace9 to 43688f2 Compare April 15, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant