CSPL-4630: add feature gate infrastructure using k8s FeatureGate pattern#1848
Open
kubabuczak wants to merge 2 commits intodevelopfrom
Open
CSPL-4630: add feature gate infrastructure using k8s FeatureGate pattern#1848kubabuczak wants to merge 2 commits intodevelopfrom
kubabuczak wants to merge 2 commits intodevelopfrom
Conversation
Introduce a feature gate registry backed by k8s.io/component-base/featuregate so new capabilities can be gated behind --feature-gates=<Gate>=true|false with Alpha/Beta/GA lifecycle. Migrate the validation webhook toggle from the ENABLE_VALIDATION_WEBHOOK env var to a ValidationWebhook feature gate with backwards-compatible env var support.
Remove non-existent Helm values snippet from FeatureGates.md, add CLI-over-env-var precedence note to ValidationWebhook.md, and log effective gate states instead of just known feature names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a feature gate registry using
k8s.io/component-base/featuregateso new controllers can be gated behind--feature-gates=<Gate>=true|falsewith Alpha/Beta/GA lifecycle. Migrate the validation webhook toggle from theENABLE_VALIDATION_WEBHOOKenv var to aValidationWebhookfeature gate with backwards-compatible env var support.Key Changes
pkg/config/withValidationWebhookgate (Alpha, off by default) and legacy env var bridgecmd/main.gofromflagtopflagand wire--feature-gatesCLI flagdocs/FeatureGates.mdwith 4-step checklist for adding new gatesdocs/ValidationWebhook.mdto reflect feature gate enablementTesting and Verification
flag→pflagmigration (1:1 rename)Related Issues
PR Checklist
test/testenv/,test/run-tests.sh,test/env.sh),docs/IntegrationTesting.mdhas been updated