Include security error body in WebFlux Cloud Foundry endpoint responses#50256
Open
htjworld wants to merge 1 commit intospring-projects:mainfrom
Open
Include security error body in WebFlux Cloud Foundry endpoint responses#50256htjworld wants to merge 1 commit intospring-projects:mainfrom
htjworld wants to merge 1 commit intospring-projects:mainfrom
Conversation
Closes spring-projectsgh-50255 Signed-off-by: htjworld <itjhan01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a Cloud Foundry security check fails in a WebFlux application,
SecureReactiveWebOperationandCloudFoundryLinksHandlerreturn onlythe HTTP status code with no response body. The servlet counterpart
includes a
{"security_error":"<reason>"}body, so the reactive pathsilently discards the diagnostic information that
SecurityInterceptoralready computes.
Change
Updated
CloudFoundryWebFluxEndpointHandlerMappingto includesecurityResponse.getMessage()as the response body in bothCloudFoundryLinksHandler.links()andSecureReactiveWebOperation.flatMapResponse(), consistent with theservlet implementation.
Tests
Updated
operationWithSecurityInterceptorForbiddenandlinksToOtherEndpointsForbiddeninCloudFoundryWebFluxEndpointIntegrationTeststo assert that thesecurity error body is present in the response.
Closes #50255