DataSourceBuilder cannot derive a DataSource from a lazy connection proxy#50271
Open
vpavic wants to merge 2 commits intospring-projects:mainfrom
Open
DataSourceBuilder cannot derive a DataSource from a lazy connection proxy#50271vpavic wants to merge 2 commits intospring-projects:mainfrom
vpavic wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
…roxy Signed-off-by: Vedran Pavic <vedran@vedranpavic.com>
a51a8b0 to
be21430
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While attempting to use newly introduced
spring.datasource.connection-fetch=lazyin a project that uses separate JDBC credentials for running Liquibase migrations I came across the issue with the following root cause:The exact scenario that led to this can be reproduced using
LiquibaseAutoConfigurationTests#lazyConnectionDataSourcetest from the first commit in this PR.At quick glance it seems the same issue can happen with Flyway and Spring Boot's database initialization and looks like a limitation of
DataSourceBuilderand its support for deriving a builder from existing data sources which second commit in this PR attempts to address.