Add SSL bundle support for JWK Set URI requests#50280
Open
bbbbooo wants to merge 2 commits intospring-projects:mainfrom
Open
Add SSL bundle support for JWK Set URI requests#50280bbbbooo wants to merge 2 commits intospring-projects:mainfrom
bbbbooo wants to merge 2 commits intospring-projects:mainfrom
Conversation
Signed-off-by: bbbbooo <hyeons1213@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
reviewed
May 4, 2026
| private void configureSsl(JwkSetUriReactiveJwtDecoderBuilder builder) { | ||
| SslBundle sslBundle = getSslBundle(); | ||
| if (sslBundle != null) { | ||
| builder.webClient(webClient(sslBundle)); |
Member
There was a problem hiding this comment.
There's quite a lot of code here that we could simplify if we add a dependency to spring-boot-webclient and use ClientHttpConnectorBuilder. I'm not sure yet if that's something we want to do. I'll flag this issue for team discussion.
| @Target({ ElementType.TYPE, ElementType.METHOD }) | ||
| @Documented | ||
| @Conditional(JwkSetUriCondition.class) | ||
| public @interface ConditionalOnJwkSetUriJwtDecoder { |
Member
There was a problem hiding this comment.
This can probably be package-private.
| * JWT decoder} should be used. | ||
| * | ||
| * @author Hyeonseok Lee | ||
| * @since 4.1.0 |
Member
There was a problem hiding this comment.
This won't make 4.1 since we're already at RC1
philwebb
added
the
for: team-meeting
Signed-off-by: bbbbooo <hyeons1213@gmail.com>
Contributor
Author
|
Thanks for the review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OAuth2 Resource Server auto-configuration supports JWK Set requests via
spring.security.oauth2.resourceserver.jwt.jwk-set-uri.However, there is no property-based way to configure the SSL context for these requests.
Applications requiring custom SSL configuration must currently provide a
JwkSetUriJwtDecoderBuilderCustomizer.Changes
spring.security.oauth2.resourceserver.jwt.jwkset.*spring.security.oauth2.resourceserver.jwt.jwk-set-urispring.security.oauth2.resourceserver.jwt.jwkset.urispring.security.oauth2.resourceserver.jwt.jwkset.ssl.bundlespring.security.oauth2.resourceserver.jwt.jwkset.ssl.enabledTests
Added and updated tests covering:
jwkset.urijwkset.uriover deprecatedjwk-set-urijwk-set-uriFixes #45180