Configure KafkaAdmin for observation#50454
Open
henriquejsza wants to merge 1 commit into
Open
Conversation
Allow KafkaTemplate and listener containers to use dedicated admin properties when looking up the Kafka cluster id for observation. Signed-off-by: henriquejsza <henriquejsza@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
Thanks for the PR! I put it on hold as I'd like some clarity on what we're trying to achieve. I've asked on the linked issue. |
Contributor
Author
|
Thanks Stéphane, totally fair. I will pause this PR until the issue discussion defines the exact goal, then I will update it accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-38830
This PR adds dedicated admin property groups for Kafka template and listener observation support. It allows the auto-configured
KafkaTemplateand listener containers to use internalKafkaAdmininstances configured fromspring.kafka.template.admin.*andspring.kafka.listener.admin.*when looking up the Kafka cluster id.The listener container customization composes with a user-provided
ContainerCustomizerso existing customization remains applied.Tests:
JAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :module:spring-boot-kafka:test --tests org.springframework.boot.kafka.autoconfigure.KafkaAutoConfigurationTests --tests org.springframework.boot.kafka.autoconfigure.ConcurrentKafkaListenerContainerFactoryConfigurerTestsJAVA_HOME=/usr/lib/jvm/java-25-openjdk-amd64 ./gradlew :module:spring-boot-kafka:checkFormat :module:spring-boot-kafka:checkstyleMain :module:spring-boot-kafka:checkstyleTestgit diff --check