Skip to content

Deprecate setAwaitTerminationSeconds in favor of setAwaitTerminationMillis#36719

Open
quaff wants to merge 1 commit intospring-projects:mainfrom
quaff:patch-133
Open

Deprecate setAwaitTerminationSeconds in favor of setAwaitTerminationMillis#36719
quaff wants to merge 1 commit intospring-projects:mainfrom
quaff:patch-133

Conversation

@quaff
Copy link
Copy Markdown
Contributor

@quaff quaff commented Apr 28, 2026

We should encourage using milliseconds over seconds for better precision, see spring-projects/spring-boot#50225

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 28, 2026
…illis

We should encourage using milliseconds over seconds for better precision, see spring-projects/spring-boot#50225

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Copy link
Copy Markdown
Contributor

@DhruvTheDev1 DhruvTheDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look like a solid move! Since we're seeing the precision loss it makes sense to deprecate setAwaitTerminationSeconds in favour of the millisecond based setter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged or decided on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants