Skip to content

feat: add route_dependencies attribute to transaction extensions#885

Merged
hrodmn merged 8 commits into
mainfrom
feat/transactions-route-dependencies
May 14, 2026
Merged

feat: add route_dependencies attribute to transaction extensions#885
hrodmn merged 8 commits into
mainfrom
feat/transactions-route-dependencies

Conversation

@hrodmn
Copy link
Copy Markdown
Collaborator

@hrodmn hrodmn commented Feb 16, 2026

resolves #884

Related Issue(s):

Description:

This adds a new argument to the TransactionExtension and BulkTransactionExtension that makes it simple to add a dependency to all routes affected by the transactions extensions. It is possible that we would want to build off of the existing add_route_dependencies pathway instead of doing this within the extension, see #884 for some discussion around that point.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'STAC FastAPI Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: a3ff0fd Previous: 2e2b0f9 Ratio
Items With Model validation (100) 116.6396950108403 iter/sec (stddev: 0.006995198306056394) 157.22439379368063 iter/sec (stddev: 0.00008602307183466387) 1.35

This comment was automatically generated by workflow using github-action-benchmark.

@jonhealy1 jonhealy1 self-requested a review April 21, 2026 16:19
@hrodmn hrodmn force-pushed the feat/transactions-route-dependencies branch from 06da220 to 1746daa Compare May 14, 2026 10:36
@hrodmn hrodmn marked this pull request as ready for review May 14, 2026 10:44
@hrodmn hrodmn marked this pull request as draft May 14, 2026 10:46
@hrodmn hrodmn marked this pull request as ready for review May 14, 2026 10:50
@hrodmn
Copy link
Copy Markdown
Collaborator Author

hrodmn commented May 14, 2026

@jonhealy1 @vincentsarago this is ready for review. I think it will be an important feature for users to safely enable the transactions extension in downstream applications like stac-fastapi-pgstac/SFEOS. Users who want more fine-grained control could still use the per-route approach that existed before but now there is an easy button to turn on authentication for all transactions routes!

@hrodmn hrodmn requested a review from vincentsarago May 14, 2026 10:53
Copy link
Copy Markdown
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This makes adding dependencies to the transaction routes a lot easier.

@jonhealy1
Copy link
Copy Markdown
Collaborator

jonhealy1 commented May 14, 2026

This same idea should be added to the catalogs transaction extension as well

@hrodmn hrodmn merged commit ee247e7 into main May 14, 2026
6 checks passed
@hrodmn hrodmn deleted the feat/transactions-route-dependencies branch May 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add optional router dependencies for TransactionExtension and BulkTransactionsExtension to facilitate adding authentication to those endpoints

3 participants