Skip to content

Move all extensions to root#899

Open
jonhealy1 wants to merge 6 commits intostac-utils:mainfrom
jonhealy1:remove-third-party-extensions
Open

Move all extensions to root#899
jonhealy1 wants to merge 6 commits intostac-utils:mainfrom
jonhealy1:remove-third-party-extensions

Conversation

@jonhealy1
Copy link
Copy Markdown
Collaborator

@jonhealy1 jonhealy1 commented Apr 2, 2026 •
edited
Loading

Related Issue(s):

Description:

  • removed the third party and core extensions folder
  • move all extensions to root
  • this is a Breaking Change as the extension import paths will now change

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@jonhealy1
Copy link
Copy Markdown
Collaborator Author

jonhealy1 commented Apr 2, 2026

Maybe these should be moved to root instead of being in the core folder?

@jonhealy1 jonhealy1 requested a review from vincentsarago April 2, 2026 16:57
@jonhealy1 jonhealy1 marked this pull request as ready for review April 2, 2026 16:57
@jonhealy1 jonhealy1 marked this pull request as draft April 2, 2026 16:59
@jonhealy1 jonhealy1 marked this pull request as ready for review April 2, 2026 17:29
@jonhealy1 jonhealy1 requested review from gadomski and hrodmn April 2, 2026 17:29
@jonhealy1 jonhealy1 changed the title Move third party extensions to core Move all extensions to root Apr 3, 2026
vincentsarago
vincentsarago reviewed Apr 3, 2026
View reviewed changes
stac_fastapi/extensions/stac_fastapi/extensions/core/__init__.py
@@ -1,39 +0,0 @@
"""stac_api.extensions.core module."""
Copy link
Copy Markdown
Member

@vincentsarago vincentsarago Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could keep this and import all the extensions to keep backward compatibility.

This is going to be an important breaking change

Copy link
Copy Markdown
Collaborator Author

@jonhealy1 jonhealy1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep all the extensions in a core folder or just try to route them via the init. I can try.

Copy link
Copy Markdown
Collaborator Author

@jonhealy1 jonhealy1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want to release a new major version because of this :)

Copy link
Copy Markdown
Member

@vincentsarago vincentsarago Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to route them via the init. I can try.

I can have a look if you want

Copy link
Copy Markdown
Collaborator Author

@jonhealy1 jonhealy1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look if you want no problem

Copy link
Copy Markdown
Collaborator Author

@jonhealy1 jonhealy1 Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha sorry got bored and figured something out

@jonhealy1 jonhealy1 requested a review from vincentsarago April 3, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski Awaiting requested review from gadomski

@hrodmn hrodmn Awaiting requested review from hrodmn

@vincentsarago vincentsarago Awaiting requested review from vincentsarago

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonhealy1 @vincentsarago @gadomski