feat(logs): Onboard access-token commands#1253
Merged
rubenhoenle merged 20 commits intomainfrom Feb 12, 2026
Merged
Conversation
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
internal/cmd/beta/logs/access_token/delete_all_expired/delete_all_expired.go
Outdated
Show resolved
Hide resolved
rubenhoenle
reviewed
Jan 30, 2026
internal/cmd/beta/logs/access_token/delete_all_expired/delete_all_expired.go
Outdated
Show resolved
Hide resolved
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
rubenhoenle
reviewed
Jan 30, 2026
Member
rubenhoenle
left a comment
There was a problem hiding this comment.
Before I even look into your next PR I will ask for implemented unit tests. It's ok this time. Just that you're aware for the future 😅
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
89d667c to
d4bf7d2
Compare
rubenhoenle
reviewed
Feb 11, 2026
rubenhoenle
reviewed
Feb 11, 2026
rubenhoenle
reviewed
Feb 11, 2026
internal/cmd/logs/access_token/delete_all_expired/delete_all_expired.go
Outdated
Show resolved
Hide resolved
rubenhoenle
reviewed
Feb 11, 2026
rubenhoenle
reviewed
Feb 11, 2026
rubenhoenle
requested changes
Feb 11, 2026
Member
rubenhoenle
left a comment
There was a problem hiding this comment.
Take care of these nil pointer dereferences, we had that in your previous PR.
rubenhoenle
reviewed
Feb 11, 2026
rubenhoenle
previously approved these changes
Feb 12, 2026
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Co-authored-by: Ruben Hönle <Ruben.Hoenle@stackit.cloud>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
rubenhoenle
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-293
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)