feat(observability): implement cert and http checks#1041
feat(observability): implement cert and http checks#1041h3adex wants to merge 3 commits intostackitcloud:mainfrom
Conversation
2b6d07a to
9f696f3
Compare
4365b5a to
e2b7fa2
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
e2b7fa2 to
cd5ca86
Compare
|
|
||
| for _, httpCheck := range *listHttpCheck.HttpChecks { | ||
| // we also check if http-check-ids are matching to support import functionality | ||
| if httpCheck.Url != nil && *httpCheck.Url == httpCheckUrl || (httpCheck.Id != nil && *httpCheck.Id == httpCheckId) { |
There was a problem hiding this comment.
Pretty hacky what you're doing here. Could you please clarify with the observability guys why there isn't a GET endpoint for a single HTTP check?
stackit/internal/services/observability/cert-check/datasource.go
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| for _, certCheck := range *createCertCheck.CertChecks { | ||
| if certCheck.Source != nil && *certCheck.Source == certCheckSource { |
There was a problem hiding this comment.
same here, why the iteration?
There was a problem hiding this comment.
@h3adex to be clear here: I won't accept this PR in the current state with the iterations. A simple GET endpoint in the service would solve this.
|
|
||
| for _, certCheck := range *listCertCheck.CertChecks { | ||
| // we also check if cert-ids are matching to support import functionality | ||
| if (certCheck.Source != nil && *certCheck.Source == certCheckSource) || (certCheck.Id != nil && *certCheck.Id == certCheckId) { |
cd5ca86 to
91940e2
Compare
|
Waiting for answer from obs-team |
91940e2 to
10a7b4a
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>
10a7b4a to
b4a3dc1
Compare


Description
This PR introduces
httpandcert_checkTerraform support. Once an HTTP or certificate check is created, you can query thanos within the observability stack for metrics (e.ghttp_response_result_code) and create alerts based on them.APIs:
https://docs.api.stackit.cloud/documentation/argus/version/v1#tag/http-check
https://docs.api.stackit.cloud/documentation/argus/version/v1#tag/cert-check
E2E Tests
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)