Debugging some failures that only occur in CI#3393
Closed
Conversation
Introduces a new MCPEmbedding custom resource to deploy HuggingFace embedding models as MCP servers in Kubernetes. This enables semantic search and similarity features for MCP tools and resources. Key Features: - Custom resource definition for embedding model deployments - Integration with HuggingFace text-embeddings-inference - Support for model caching via PersistentVolumeClaims - Flexible resource configuration and pod customization - GroupRef support for organizational grouping - Comprehensive status conditions and phase tracking Components: - MCPEmbedding CRD with validation and webhook support - Controller for managing deployment lifecycle - Generated CRD manifests and Helm chart templates - RBAC permissions for managing embeddings - Example configurations for various use cases This change is based on the original commit by rebasing onto jerm/2026-01-13-optimizer-in-vmcp to remove intermediate commits. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
… support This refactors the EmbeddingServer controller with the following changes: - Convert from Deployment to StatefulSet for better persistent storage support - Add HFTokenSecretRef field for secure HuggingFace token injection from Kubernetes secrets - Use StatefulSet volumeClaimTemplates for model cache PVCs instead of separate PVC creation - Remove Env field from EmbeddingDeploymentOverrides API - Add comprehensive controller unit tests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Regenerate Helm chart READMEs with helm-docs to reflect version 0.5.26 and fix table formatting. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
github-actions
bot
added
size/XL
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3393 +/- ##
==========================================
- Coverage 64.82% 64.40% -0.43%
==========================================
Files 375 377 +2
Lines 36626 37275 +649
==========================================
+ Hits 23744 24006 +262
- Misses 11011 11352 +341
- Partials 1871 1917 +46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Will cherry-pick the debugging capabilities into a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.