Skip to content

fix(tests): Add new CVE to logstash-7.13.3 test#3449

Merged
rhybrillou merged 2 commits into
masterfrom
yann/e2etest/logstash-7.13.3/log4j-2.14.0/cve-2026-49844wq
Jul 21, 2026
Merged

fix(tests): Add new CVE to logstash-7.13.3 test#3449
rhybrillou merged 2 commits into
masterfrom
yann/e2etest/logstash-7.13.3/log4j-2.14.0/cve-2026-49844wq

Conversation

@rhybrillou

Copy link
Copy Markdown
Contributor

No description provided.

@rhybrillou
rhybrillou requested a review from a team as a code owner July 21, 2026 08:51
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9ee915b0-3632-48bd-957a-ac1c31b092ff

📥 Commits

Reviewing files that changed from the base of the PR and between 2caccec and 16dbfe8.

📒 Files selected for processing (1)
  • e2etests/testcase_test.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • e2etests/testcase_test.go

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated Log4j end-to-end vulnerability expectations to add CVE-2026-49844.
    • Included full vulnerability details (description, NVD scoring metadata) and marked severity as Moderate.
    • Updated the Log4j feature’s expected fixed version from 2.25.4 to 2.25.5.

Walkthrough

The Log4j E2E test expectations now include CVE-2026-49844 with its vulnerability metadata, Moderate severity, and fixed version 2.25.5.

Changes

Log4j E2E expectations

Layer / File(s) Summary
Update Log4j vulnerability expectations
e2etests/testcase_test.go
Adds CVE-2026-49844 with its description, NVD metadata, Moderate severity, and FixedBy value 2.25.5; updates the Log4j feature’s expected fixed version from 2.25.4 to 2.25.5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, so there is not enough text to judge whether it matches the change. Add a brief description of the test data update and the new CVE entry.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: adding a new CVE to the logstash/log4j test data.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yann/e2etest/logstash-7.13.3/log4j-2.14.0/cve-2026-49844wq

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@e2etests/testcase_test.go`:
- Line 3342: Update the enclosing Log4j feature’s FixedBy value to "2.25.5" so
it matches the nested entry’s remediation version and the aggregate expectation
reflects all listed vulnerabilities.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5b0b9990-8e94-420a-b72e-855ae090c933

📥 Commits

Reviewing files that changed from the base of the PR and between c58c650 and 2caccec.

📒 Files selected for processing (1)
  • e2etests/testcase_test.go

Comment thread e2etests/testcase_test.go
@rhybrillou
rhybrillou merged commit d5e6731 into master Jul 21, 2026
36 checks passed
@rhybrillou
rhybrillou deleted the yann/e2etest/logstash-7.13.3/log4j-2.14.0/cve-2026-49844wq branch July 21, 2026 15:37
@rhacs-bot

Copy link
Copy Markdown

The backport to release-2.40 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.40 release-2.40
# Navigate to the new working tree
cd .worktrees/backport-release-2.40
# Create a new branch
git switch --create backport-3449-to-release-2.40
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d5e6731e0d3507768fe2312033335f9125cb490e
# Push it to GitHub
git push --set-upstream origin backport-3449-to-release-2.40
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.40

Then, create a pull request where the base branch is release-2.40 and the compare/head branch is backport-3449-to-release-2.40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants