ROX-33862: fix ignored explicit telemetry key

[parametalol]

Description

When a telemetry storage key is explicitly provided (e.g. via ROX_TELEMETRY_STORAGE_KEY_V1), the Reconfigure method was overwriting it with the key fetched from the remote configuration endpoint. This caused explicitly configured environments to lose their intended key.

The fix skips updating the storage key from remote config when an explicit key was provided, unless the remote key is DISABLED — which must always take effect to allow telemetry to be shut down remotely.

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

How I validated my change

• Added unit tests covering: explicit key preserved on reconfigure, explicit key overridden by DISABLED, and telemeter not reset when key is unchanged.
• Modified existing test to use a channel for synchronization instead of relying on eventual.Value blocking.
• Adjusted the "new telemeter on reconfigure" test to use a downloaded (non-explicit) key scenario, verifying the telemeter is properly reset only when the downloaded key changes.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rhacs-bot]

Images are ready for the commit at 7d9a62d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-465-g7d9a62ddac.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.39%. Comparing base (54d515d) to head (7d9a62d).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #19651      +/-   ##
==========================================
+ Coverage   49.37%   49.39%   +0.02%     
==========================================
  Files        2742     2745       +3     
  Lines      206953   207228     +275     
==========================================
+ Hits       102187   102369     +182     
- Misses      97182    97267      +85     
- Partials     7584     7592       +8     

Flag	Coverage Δ
go-unit-tests	49.39% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[openshift-ci]

@parametalol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/gke-operator-e2e-tests	7d9a62d	link	false	/test gke-operator-e2e-tests
ci/prow/gke-upgrade-tests	7d9a62d	link	false	/test gke-upgrade-tests
ci/prow/gke-nongroovy-e2e-tests	7d9a62d	link	true	/test gke-nongroovy-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests	7d9a62d	link	false	/test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests	7d9a62d	link	false	/test ocp-4-12-nongroovy-e2e-tests
ci/prow/gke-qa-e2e-tests	7d9a62d	link	false	/test gke-qa-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests	7d9a62d	link	false	/test ocp-4-21-nongroovy-e2e-tests
ci/prow/ocp-4-21-operator-e2e-tests	7d9a62d	link	false	/test ocp-4-21-operator-e2e-tests
ci/prow/ocp-4-21-qa-e2e-tests	7d9a62d	link	false	/test ocp-4-21-qa-e2e-tests
ci/prow/ocp-4-12-qa-e2e-tests	7d9a62d	link	false	/test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.