Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Make import.meta.glob eager so Rolldown doesn't tree-shake the image assets out of the Vite manifest, which broke favicon loading in the CP. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades Vite from v7 to v8 (Rolldown-based bundler) along with required dependency changes.
Dependency changes
vite^7.3.2 → ^8.0.0laravel-vite-plugin^2.0.0 → ^3.0.0 (required for Vite 8)rollup-plugin-visualizer^5.14.0 → ^7.0.0 (required for Rolldown compatibility)vite-tsconfig-paths— Vite 8 resolves tsconfig paths natively via RolldownConfig changes (
vite.config.js)vite-tsconfig-pathsplugin, addedresolve.tsconfigPaths: truerollup-plugin-visualizerfrombuild.rollupOptions.output.pluginsto top-levelpluginsarray (required by Vite 8)build.rollupOptionsCode fixes
resources/js/index.js— Madeimport.meta.glob(['../img/**'])eager. Rolldown tree-shakes unused lazy glob results, which removed favicon/image assets from the Vite manifest, breakingStatamic::cpViteAsset()lookups in the CPresources/js/pages/collections/Scaffold.vue— Changedconststring bindings toref()forv-modelcompatibility. The Vue compiler in this version errors onv-modelwith non-reactiveconstbindings in<script setup>resources/css/components/preview.css— Fixed@-4xl/live-preview→@4xl/live-preview. The@-{size}syntax was never valid in Tailwind v4; the lockfile regeneration pulled in Tailwind 4.2 which now errors on invalid variantsTest plan
npm run buildsucceeds, favicon entries present in manifestnpm run build-devsucceeds, favicon entries present in manifestnpm run frontend-buildproducesresources/dist-frontend/js/helpers.jsnpm run test— 67 test files, 544 tests pass