[6.x] Fix form submissions with non-UTF-8 data crashing the CP listing#14461
Merged
jasonvarga merged 2 commits into6.xfrom Apr 8, 2026
Merged
[6.x] Fix form submissions with non-UTF-8 data crashing the CP listing#14461jasonvarga merged 2 commits into6.xfrom
jasonvarga merged 2 commits into6.xfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where form submissions containing non-UTF-8 bytes (e.g. from spam bots injecting binary data, or copy-pasted text from Word/Google Docs containing control characters) would crash the entire CP forms listing.
This was happening because Symfony's YAML dumper stores non-UTF-8 values using the
!!binarytag with base64 encoding. This is valid YAML, so the existingParseExceptioncatch inFormSubmissionsStore::makeItemFromFile()doesn't trigger. The decoded binary data then passes through to the CP's JSON response, wherejson_encode()throws anInvalidArgumentException: Malformed UTF-8 characters.This PR fixes it by sanitizing parsed submission data after YAML parsing, stripping any invalid UTF-8 bytes before the data reaches JSON serialization.
Fixes #14447