Skip to content

build: add wasm configurations - #13771

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
anandkaranubc:build/ext-base-wasm
Jul 30, 2026
Merged

build: add wasm configurations#13771
kgryte merged 2 commits into
stdlib-js:developfrom
anandkaranubc:build/ext-base-wasm

Conversation

@anandkaranubc

@anandkaranubc anandkaranubc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds wasm configuration to blas/ext/base manifest

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Cursor+VS Code code-generation tools to help assist with the feature.

@stdlib-js/reviewers

@anandkaranubc
build: add wasm configuration to blas/ext/base manifest
5ae9c7c 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@anandkaranubc
anandkaranubc requested a review from a team July 30, 2026 03:45
anandkaranubc
anandkaranubc commented Jul 30, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/sapxsumpw/package.json
"__stdlib__": {
"wasm": false
}
"__stdlib__": {}

@anandkaranubc anandkaranubc Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should complex packages in blas/ext/base also include this package.json change?

@kgryte kgryte Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine, IIRC. But also leaving as is is fine, as well.

@kgryte kgryte Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is more important for when a WebAssembly implementation IS present "wasm": true, as this allows us to search for packages with wasm implementations based on package meta data.

There was a time when wasm implementations were not separate packages and explicitly setting the wasm field was a means to avoid needing to check for source files. We've since evolved since then. So, in short, this change is fine, but the status quo is also harmless.

anandkaranubc
anandkaranubc commented Jul 30, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/sapxsumpw/manifest.json
},
{
"task": "examples",
"task": "build",

@anandkaranubc anandkaranubc Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess if I can understand why we have some variations of this in the blas/ext/base packages, or why we have these in our implementations, it would give me a better picture of what to consider when making this kind of change, deciding whether to include it in future implementations, and determining which implementations should include it.

cc: @kgryte

@anandkaranubc anandkaranubc Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR were only made because I noticed this inconsistency in the existing packages, including the ones I recently added.

@kgryte kgryte Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In short, we incrementally updated the manifest.json files as we added WebAssembly implementations. It is fine to go ahead and preemptively add the wasm configurations. So, what you are seeing wrt variations stems from the in-progress wasm work (see the blas/ext/base/wasm namespace for reference).

@kgryte kgryte Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/stdlib-js/stdlib/pull/5630/changes for an example of what I am referring to by incremental migration.

@anandkaranubc anandkaranubc added Needs Review A pull request which needs code review. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). METR Pull request associated with the METR project. labels Jul 30, 2026
@stdlib-bot

stdlib-bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/capx $\\color{green}441/441$
$\\color{green}+0.00\\%$ 		$\\color{green}29/29$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}441/441$
$\\color{green}+0.00\\%$
blas/ext/base/caxpb $\\color{green}457/457$
$\\color{green}+0.00\\%$ 		$\\color{green}32/32$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}457/457$
$\\color{green}+0.00\\%$
blas/ext/base/dwxmy $\\color{green}426/426$
$\\color{green}+0.00\\%$ 		$\\color{green}28/28$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}426/426$
$\\color{green}+0.00\\%$
blas/ext/base/dwxpy $\\color{green}426/426$
$\\color{green}+0.00\\%$ 		$\\color{green}28/28$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}426/426$
$\\color{green}+0.00\\%$
blas/ext/base/sapx $\\color{green}388/388$
$\\color{green}+0.00\\%$ 		$\\color{green}26/26$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}388/388$
$\\color{green}+0.00\\%$
blas/ext/base/sapxsum $\\color{green}349/349$
$\\color{green}+0.00\\%$ 		$\\color{green}13/13$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}349/349$
$\\color{green}+0.00\\%$
blas/ext/base/sapxsumors $\\color{green}353/353$
$\\color{green}+0.00\\%$ 		$\\color{green}15/15$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}353/353$
$\\color{green}+0.00\\%$
blas/ext/base/sapxsumpw $\\color{green}369/369$
$\\color{green}+0.00\\%$ 		$\\color{green}15/15$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}369/369$
$\\color{green}+0.00\\%$
blas/ext/base/sasumpw $\\color{green}436/436$
$\\color{green}+0.00\\%$ 		$\\color{green}24/24$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}436/436$
$\\color{green}+0.00\\%$
blas/ext/base/snansumkbn2 $\\color{green}407/407$
$\\color{green}+0.00\\%$ 		$\\color{green}25/25$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}407/407$
$\\color{green}+0.00\\%$
blas/ext/base/snansumpw $\\color{green}457/457$
$\\color{green}+0.00\\%$ 		$\\color{green}59/59$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}457/457$
$\\color{green}+0.00\\%$
blas/ext/base/ssumors $\\color{green}362/362$
$\\color{green}+0.00\\%$ 		$\\color{green}19/19$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}362/362$
$\\color{green}+0.00\\%$
blas/ext/base/ssumpw $\\color{green}436/436$
$\\color{green}+0.00\\%$ 		$\\color{green}24/24$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}436/436$
$\\color{green}+0.00\\%$
blas/ext/base/zapx $\\color{green}441/441$
$\\color{green}+0.00\\%$ 		$\\color{green}29/29$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}441/441$
$\\color{green}+0.00\\%$
blas/ext/base/zaxpb $\\color{green}457/457$
$\\color{green}+0.00\\%$ 		$\\color{green}32/32$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}457/457$
$\\color{green}+0.00\\%$
blas/ext/base/znancount $\\color{green}367/367$
$\\color{green}+0.00\\%$ 		$\\color{green}19/19$
$\\color{green}+0.00\\%$ 		$\\color{green}4/4$
$\\color{green}+0.00\\%$ 		$\\color{green}367/367$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Jul 30, 2026
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/ext/base/snansumkbn2/package.json Outdated
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 30, 2026
@kgryte kgryte changed the title build: add wasm configuration to blas/ext/base manifest build: add wasm configurations Jul 30, 2026
@kgryte
kgryte merged commit abe2e55 into stdlib-js:develop Jul 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). METR Pull request associated with the METR project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anandkaranubc @stdlib-bot @kgryte