-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: clarify role of N and in-place behavior in cumax #9959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
-[x] Read,understood, and followed the contribution guidelines
|
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YOGigx Thank you for your interest in stdlib and for opening this PR. While we appreciate the sentiment behind this PR, we won't be accepting the proposed change, as the content of the note is already covered by existing documentation and examples.
Thanks again, and we look forward to your future contributions! 🚀
|
"Hi @kgryte, Thank you for the reviewing and the clarification! I 'll look for other areas where I can contribute without duplicating existing documentation. Thanks again! |
Resolves #{{TODO: add issue number}}.
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers