Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares Stellar CLI for Protocol 26 by updating core Soroban/Stellar dependency versions and aligning CLI behavior/docs/CI with the updated tooling (including removal of deprecated global/plugin listing flags).
Changes:
- Bump workspace dependencies (Stellar XDR v26, Soroban v26 RC, assorted libs) and refresh
Cargo.lock. - Remove deprecated CLI flags (
--global,--list) and update generated help docs accordingly; add help content for newstellar xdr xfilecommand. - Update CI workflows to run Quickstart with
protocol_version: 26, and adjust ledger HD path encoding implementation/tests after removingslipped10.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
FULL_HELP_DOCS.md |
Updates generated CLI help output to match removed flags and new XDR subcommands/options. |
deny.toml |
Updates cargo-deny configuration (licenses, ignores, duplicate-skip entries, git source formatting). |
cmd/soroban-cli/src/config/locator.rs |
Removes deprecated --global arg and its warning; global config path becomes the default. |
cmd/soroban-cli/src/config/data.rs |
Extends persisted transaction response data to include newly available RPC fields. |
cmd/soroban-cli/src/commands/network/ls.rs |
Adjusts long listing logic after removal of --global (currently introduces a bug). |
cmd/soroban-cli/src/commands/mod.rs |
Removes deprecated --list handling and --global deprecation messaging from root command execution. |
cmd/soroban-cli/src/commands/message/verify.rs |
Updates tests/fixtures for locator::Args after removing global field. |
cmd/soroban-cli/src/commands/message/sign.rs |
Updates tests/fixtures for locator::Args after removing global field. |
cmd/soroban-cli/src/commands/keys/generate.rs |
Updates tests/fixtures for locator::Args after removing global field. |
cmd/soroban-cli/src/commands/global.rs |
Removes deprecated --list option from global args. |
cmd/soroban-cli/src/commands/contract/invoke.rs |
Removes now-nonexistent list field when constructing global args. |
cmd/crates/stellar-ledger/src/hd_path.rs |
Replaces slipped10 BIP32 path encoding with local hardened-index encoding + tests. |
cmd/crates/stellar-ledger/Cargo.toml |
Drops slipped10 dependency. |
cmd/crates/soroban-test/tests/it/integration/hello_world.rs |
Updates integration test locator args construction (no global field). |
cmd/crates/soroban-test/src/lib.rs |
Updates test env locator args construction (no global field). |
Cargo.toml |
Bumps workspace dependency versions for Protocol 26 support and related dependency updates. |
Cargo.lock |
Lockfile refresh reflecting all dependency upgrades/removals/additions. |
.github/workflows/rpc-tests.yml |
Runs Quickstart with Protocol 26 for RPC tests. |
.github/workflows/bindings-ts.yml |
Runs Quickstart with Protocol 26 for TS bindings workflow. |
.github/copilot-instructions.md |
Updates documented minimum Rust toolchain version requirement. |
mootz12
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prepare for Protocol 26 release. This basically updates dependencies.
Why
So we can support p26.
Known limitations
N/A