Change the set_status function to opt all plugins in or out simultaneously.#100
Open
Change the set_status function to opt all plugins in or out simultaneously.#100
Conversation
Contributor
Author
|
Context on test fatal: WordPress/WordPress-Coding-Standards#2219 To correct/prevent the fatal, I've updated both |
lucatume
suggested changes
Nov 20, 2023
| $option['plugins'][ $stellar_slug ]['optin'] = $status; | ||
|
|
||
| // Force the others to all match. | ||
| foreach ( $option['plugins'] as &$plugin_data ) { |
Contributor
There was a problem hiding this comment.
At this line you've added a check to make sure the $option['plugins'] will default to an empty array if not set; the same possibility of the $option['plugins'] variable not being set should be handled here:
`if( isset( $option['plugins'])) { foreach ... }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus opting into one plugin opts into all, and opting out of one opts out of all. Makes the "mixed" status obsolete.