docs: add TypeScript MCP elicitation examples#790
docs: add TypeScript MCP elicitation examples#790gautamsirdeshmukh wants to merge 1 commit intostrands-agents:mainfrom
Conversation
Documentation Preview ReadyYour documentation preview has been successfully deployed! Preview URL: https://d3ehv1nix5p99z.cloudfront.net/pr-cms-790/docs/user-guide/quickstart/overview/ Updated at: 2026-04-28T19:28:06.541Z |
bd2eaaf to
a85dbaf
Compare
|
Assessment: Comment Good, well-scoped PR that adds TypeScript elicitation examples matching the existing Python structure. Two issues to address before merge: a Review Details
The examples themselves are clear, well-structured, and consistent with the Python counterparts. 👍 |
a85dbaf to
88af0ae
Compare
88af0ae to
21c15e7
Compare
|
Assessment: Comment Good progress — the Review Details
The examples themselves are well-written and match the Python counterpart structure nicely. |
|
Assessment: Approve Both issues from previous reviews have been addressed — the |
21c15e7 to
fa8df7d
Compare
|
|
||
| // --8<-- [start:elicitation_client] | ||
| // client.ts | ||
| import type { ElicitationCallback } from '@strands-agents/sdk' |
There was a problem hiding this comment.
Issue: The elicitation_client snippet uses McpClient, StdioClientTransport, and Agent without importing them. Unlike mcp-tools.ts where these are imported at the file top and shared across all snippets, this is a separate file so the client snippet is missing its imports. The Python counterpart includes all necessary imports (from strands import Agent, from strands.tools.mcp import MCPClient, etc.), so readers copying the TypeScript client code won't have the full picture.
Suggestion: Add the missing imports inside the elicitation_client snippet:
// --8<-- [start:elicitation_client]
// client.ts
import { Agent, McpClient } from '@strands-agents/sdk'
import { StdioClientTransport } from '@modelcontextprotocol/sdk/client/stdio.js'
import type { ElicitationCallback } from '@strands-agents/sdk'
// ... rest of snippetThere was a problem hiding this comment.
Confirmed resolved — all three imports (Agent, McpClient, ElicitationCallback, StdioClientTransport) are present in the elicitation_client snippet.
|
Assessment: Comment All four previous review issues are resolved — great iteration. One new item: the client snippet is missing imports for Review Details
|
fa8df7d to
7932119
Compare
7932119 to
b210fe8
Compare
|
Assessment: Approve All substantive issues from previous reviews are resolved. The dedicated |
b210fe8 to
1ca105e
Compare
|
Assessment: Approve No changes since the last approval. All previously raised issues remain resolved: |
1ca105e to
5d0afad
Compare
|
Assessment: Approve The heading restructure in this latest push is a clean solution — moving |
5d0afad to
8520272
Compare
|
Assessment: Approve No substantive changes since the last approval (likely a rebase). Preview is now up to date and confirms single |
|
Should refactor to fix CI failure? |
Description
Adds TypeScript examples to the MCP elicitation docs section, which previously said "Not supported in TypeScript." Includes both a server-side example using elicitInput() and a client-side example using the new elicitationCallback config, matching the structure of the existing Python examples.
Related Issues
Docs for strands-agents/sdk-typescript#232
Type of Change
Checklist
npm run devBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.