chore: merge strands-agents/docs into monorepo#2339
Merged
zastrowm merged 567 commits intoMay 27, 2026
Conversation
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
…ents#505) Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
…agents#514) Co-authored-by: strands-agent <217235299+strands-agent@users.noreply.github.com> Co-authored-by: Patrick Gray <pgrayy@amazon.com>
…ents#504) Co-authored-by: Francesco Cerizzi <francesco@MacBook-Pro-di-Francesco.local>
Co-authored-by: Strands Agent <217235299+strands-agent@users.noreply.github.com>
…agents#522) Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
…s#527) Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
…agents#541) Co-authored-by: Mackenzie Zastrow <zastrowm@users.noreply.github.com>
Contributor
|
Assessment: Comment The CI gate architecture is well-designed — the Review Categories
Solid convergence work — the conflict resolution table in the PR description is particularly helpful for reviewers. |
JackYPCOnline
previously approved these changes
May 27, 2026
- Remove docs-auto-strands-review.yml (shared workflow covers it) - Upgrade actions/checkout and actions/setup-node from @v4 to @v6 - Upgrade actions/github-script from @v7 to @v8 - Switch npm install to npm ci in CI workflows for deterministic builds - Add .github/workflows/ci.yml to path filters so changes to the gate itself trigger both test suites
6a0d056 to
30b6313
Compare
Contributor
|
Assessment: Approve The updates since the last review addressed the key feedback — action versions, Remaining Items
Clean convergence work — the CI gate pattern is solid and the workflow consolidation is well thought through. |
JackYPCOnline
approved these changes
May 27, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge the
strands-agents/docsrepository into the monorepo with full commit history preserved (564 commits). The docs repo's content lands atsite/(Astro documentation site) anddesigns/(design documents at repo root), matching the layout defined in the convergence plan.Key decisions:
docs-prefix with path filters (site/**,.github/workflows/docs-*) — no renaming needed.gitignoreupdated to allow.kiro/skillsand.kiro/referencessymlinks (pointing to.agents/)site/.gitignoreun-gitignoredpackage-lock.jsonand a lockfile was generated sonpm ciworks in CIdependabot.ymlgained an npm entry for/sitewithci(docs)commit prefix.agents/) brought in for docs workflow toolingdocs-auto-strands-review.yml(sharedauto-strands-review.ymlalready covers it)Conflict resolutions:
README.md.github/PULL_REQUEST_TEMPLATE.md.gitignore.kirorule relaxed for symlinks.github/dependabot.yml/siteentryCI merge-gate workflow
Adds a new
ci.ymlworkflow that solves the monorepo path-filtering problem: when required status checks come from path-filtered workflows, PRs that don't touch those paths can never merge because the checks never report.How it works:
ci.ymlalways runs on PRs, usesdorny/paths-filterto detect which areas changedpython-test-lint.ymland/ordocs-ci.ymlviaworkflow_callCI Gatejob (usingre-actors/alls-green) aggregates results — skipped jobs pass, failed jobs failpython-pr-and-push.yml,docs-ci.yml) no longer havepull_requesttriggers to avoid duplicate runsRuleset change required: Replace the 10 individual
call-test-lint/*required checks with a singleCI Gatecheck.Related Issues
#2286
Documentation PR
N/A — this PR is the docs merge.
Type of Change
Other (please describe): Repository convergence — merging docs repo history into the monorepo + CI gate workflow.
Testing
Both workflows validated on fork (zastrowm/sdk-python) via
workflow_dispatchand on the PR itself:CI Gate — passed (Python skipped correctly on docs-only changes, Docs CI ran and passed)
CI Gate — passed (both Python and Docs ran when workflow files were touched)
Python: Pull Request and Push — no longer triggers on PRs (only push-to-main + dispatch)
I ran
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.