fix(ci): skip Docker login, push and Scout steps for fork PRs#788
Merged
Conversation
The Docker build workflow already had a correct push condition but the registry login and Docker Scout steps ran unconditionally. For fork PRs the pushed image does not exist so Scout would fail; this change guards both steps with the same same-repo condition so fork PRs only build the image without pushing or scanning.
UlysseCorbeil
approved these changes
May 22, 2026
Contributor
UlysseCorbeil
left a comment
UlysseCorbeil
left a comment
There was a problem hiding this comment.
is .dev/todo supposed to be merged in ?
Contributor
Author
Yes and no :) I'm not sure, removing for now and I'll continue to ponder if it's something we should or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker build workflow already had a correct push condition but the registry login and Docker Scout steps ran unconditionally. For fork PRs the pushed image does not exist so Scout would fail; this change guards both steps with the same same-repo condition so fork PRs only build the image without pushing or scanning.