Chore/multi prop selector - #587
Merged
Merged
Conversation
ColorPicker.vue imports vue-color's JS but not its CSS, and vue-color ships the two separately. src/main.ts (the local demo app) imports 'vue-color/style.css' itself, which masked the gap: that only styles the demo site, since consumers of dist/beaker.es.js never pull in anything main.ts imports. src/system.ts is the actual published entry (built via vite-publish.config.js into dist/style.css), and it had no such import, so ColorPicker rendered with no gradients, sliders, or handle styling in any consuming app. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
multipleprop to theSelector.vuecomponent, allowing consumers to enable multiple selection mode.Imported
vue-color/style.cssinsystem.tsto ensure that theColorPickercomponent is correctly styled in all consuming applications, preventing unstyled rendering issues.