fix: support DEFERRABLE attribute on unique constraints#274
Open
joaquinhuigomez wants to merge 1 commit intostripe:mainfrom
Open
fix: support DEFERRABLE attribute on unique constraints#274joaquinhuigomez wants to merge 1 commit intostripe:mainfrom
joaquinhuigomez wants to merge 1 commit intostripe:mainfrom
Conversation
Read condeferrable and condeferred from pg_constraint during schema introspection. Include deferrable state in constraint comparison and DDL generation to prevent spurious diffs. Closes stripe#273
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
condeferrableandcondeferredfrompg_constraintduring schema introspection. Include deferrable state in constraint comparison and DDL generation.Previously, deferrable unique constraints always produced a spurious diff because the tool didn't track the deferrable attribute. When recreating the constraint via
ADD CONSTRAINT ... UNIQUE USING INDEX, theDEFERRABLE/INITIALLY DEFERREDclause was omitted, so the regenerated schema never matched the original.Changes:
queries.sql/queries.sql.go: fetchcondeferrableandcondeferredfrompg_constraintin the GetIndexes queryschema.go: addIsDeferrableandIsInitiallyDeferredfields toIndexConstraintsql_generator.go: appendDEFERRABLE INITIALLY DEFERREDorDEFERRABLE INITIALLY IMMEDIATEto theADD CONSTRAINT ... USING INDEXDDL when applicableindex_cases_test.go: acceptance tests for adding, no-op, and changing deferrable unique constraintsCloses #273