Skip to content

Conversation

@cstockton
Copy link
Contributor

@cstockton cstockton commented Dec 9, 2025

Increase tests coverage and verify phone change functionality in response to supabase/supabase#40797

  • Add defensive change to anonymous rate limits test
    • This function relies on low anon rate limit (loops over rate limit)
  • Rename getAccessToken to getEmailAccessToken and add generic getAccessToken helper
  • Rename signupAndConfirm to signupAndConfirmEmail
  • Expand phone signup and phone change e2e tests:
    • Capture and verify OTP from SendSMS hook
    • Validate one-time token creation and user state transitions
    • Add full phone change flow, including OTP verification
  • Update MFA-related tests to use new helper names

@cstockton cstockton requested a review from a team as a code owner December 9, 2025 18:48
@cstockton cstockton force-pushed the cs/e2e-tests-phone-confirm-and-change branch from b5441ef to 705cf4f Compare December 9, 2025 19:06
- Add defensive change to anonymous rate limits test
  - This function relies on low anon rate limit (loops over rate limit)
- Rename getAccessToken to getEmailAccessToken, add generic getAccessToken
- Rename signupAndConfirm to signupAndConfirmEmail
- Expand phone signup and phone change e2e tests:
  - Capture and verify OTP from SendSMS hook
  - Validate one-time token creation and user state transitions
  - Add full phone change flow, including OTP verification
- Update MFA-related tests to use new helper names
@coveralls
Copy link

coveralls commented Dec 9, 2025

Pull Request Test Coverage Report for Build 20075653784

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 68.527%

Totals Coverage Status
Change from base Build 20069619121: 0.06%
Covered Lines: 14682
Relevant Lines: 21425

💛 - Coveralls

Copy link
Contributor

@issuedat issuedat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions 👏 👏

@cstockton cstockton merged commit db40e28 into master Dec 9, 2025
7 checks passed
@cstockton cstockton deleted the cs/e2e-tests-phone-confirm-and-change branch December 9, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants