fix: allow linking no-email OIDC identity to phone-only users - #2645
Open
rohanpatel2002 wants to merge 1 commit into
Open
fix: allow linking no-email OIDC identity to phone-only users#2645rohanpatel2002 wants to merge 1 commit into
rohanpatel2002 wants to merge 1 commit into
Conversation
Skip email confirmation in linkIdentityToUser when the primary email remains empty after UpdateUserEmailFromIdentities (email-optional OIDC). Fixes supabase#2640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
linkIdentityToUsertreats an empty primary email as “identity claimed an unverified email,” so phone-only users linking an email-optional OIDC identity with no email hitsendConfirmationand get 422EmailNotConfirmed.Fixes #2640
What is the new behavior?
After
UpdateUserEmailFromIdentities, email confirmation /Confirmonly runs whenGetEmail() != "". Anonymous → non-anonymous still runs. Phone-only + no-email OIDC link succeeds.Additional context
Regression test:
TestLinkIdentityToUser_PhoneOnlyNoEmail.