Skip to content

chore(supabase_flutter): mark auth-url helpers @internal instead of parse-ignore#1510

Merged
spydon merged 2 commits into
mainfrom
chore/replace-parse-ignore-with-internal
Jul 2, 2026
Merged

chore(supabase_flutter): mark auth-url helpers @internal instead of parse-ignore#1510
spydon merged 2 commits into
mainfrom
chore/replace-parse-ignore-with-internal

Conversation

@spydon

@spydon spydon commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What

Replaces the three .sdk-parse-ignore entries for the clear-auth-url helpers with @internal annotations on the declarations, and removes those entries.

Why

The SDK capability-matrix symbol extractor now honours @internal (from package:meta), see supabase/sdk#54. Before that, the extractor treated every non-underscore lib/src declaration as public API, so the internal auth-url helpers had to be excluded by path in .sdk-parse-ignore.

@internal on the declaration is a better source of truth than a hand-maintained path list: it lives next to the code, travels with refactors, and documents intent directly.

What changed

  • removeAuthParametersFromUrl (clear_auth_url_parameters.dart) marked @internal.
  • clearAuthUrlParameters in both conditional-import shims (clear_auth_url_parameters_web.dart, clear_auth_url_parameters_stub.dart) marked @internal.
  • Removed the three entries from .sdk-parse-ignore; its header now points to @internal as the preferred mechanism and reserves the file for paths that cannot carry the annotation (for example generated sources).

All three symbols are used only within supabase_flutter, so @internal produces no cross-package analyzer warnings. Verified against the updated extractor that the package no longer emits these symbols while its other 466 public symbols are unchanged.

…arse-ignore

The SDK symbol extractor now honours @internal (from package:meta), so the
internal clear-auth-url helpers no longer need to be listed in
.sdk-parse-ignore. Annotate removeAuthParametersFromUrl and the conditional
clearAuthUrlParameters shims @internal and drop their entries, leaving the
ignore file for paths that cannot carry the annotation.
@spydon spydon requested a review from a team as a code owner July 1, 2026 17:33
@spydon spydon merged commit 682dd96 into main Jul 2, 2026
22 checks passed
@spydon spydon deleted the chore/replace-parse-ignore-with-internal branch July 2, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants