fix: persist all messages in multi-step tool calls#2
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
fix: persist all messages in multi-step tool calls#2seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
AI_APICallErrorwhere Anthropic rejected API calls due totool_useIDs without correspondingtool_resultblocks immediately after them.Root Cause:
The
onFinishhandler inapp/(chat)/api/chat/route.tswas incorrectly saving only a single assistant message from theappendResponseMessagesoutput. WhenstreamTextused tools withmaxSteps > 1, it generated multiple messages (e.g.,assistant[tool_use],user[tool_result],assistant[text]). However, only the first assistant message (often thetool_useblock) was persisted to the database, leading to a corrupted conversation history wheretool_useblocks were not followed bytool_resultblocks.Solution:
The
onFinishhandler has been updated to correctly save all relevant messages generated byappendResponseMessages(excluding the initial user message). This ensures thattool_useandtool_resultpairs, along with the final assistant response, are fully persisted in the database, maintaining a valid conversation history for the LLM API.Fixes SUPERMEMORY-BACKEND-ZW3