fix: remove broken build:lib step and unused esbuild dependency#46
Open
vorflux[bot] wants to merge 3 commits intomainfrom
Open
fix: remove broken build:lib step and unused esbuild dependency#46vorflux[bot] wants to merge 3 commits intomainfrom
vorflux[bot] wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #45 was merged before the final three fix commits landed on the branch. Those commits were pushed after the merge, so they weren't included. This PR applies those missing fixes to
main.Changes
Removed broken
Buildstep from publish workflow -- The step ranbun run build:libwhich callsesbuild lib/validate.ts, butlib/validate.tsdoesn't exist in the repo (only the pre-builtlib/validate.jsandlib/validate.d.tsare committed). This caused every publish attempt to fail withCould not resolve "lib/validate.ts".Removed broken
build:libscript frompackage.json-- The script referenced the non-existentlib/validate.tsfile.Removed unused
esbuilddevDependency -- Only used by the now-removedbuild:libscript.Regenerated
bun.lock-- Removingesbuildfrom devDependencies made the lockfile stale, causingbun install --frozen-lockfileto fail in CI. Regenerated the lockfile to match the updatedpackage.json.Testing
package.jsonretains tab indentation (Biome requirement),repositoryfield, and all other fieldsbuild:libno longer appears in workflow or package.jsonesbuildno longer appears in devDependenciesContext
See the publish workflow failure screenshot from the user -- the
Buildstep fails with:This blocks all npm publishes for this package.
Session Details
(aside)to your comment to have me ignore it.