Skip to content

fix: remove broken build:lib step and unused esbuild dependency#46

Open
vorflux[bot] wants to merge 3 commits intomainfrom
vorflux/fix-broken-build
Open

fix: remove broken build:lib step and unused esbuild dependency#46
vorflux[bot] wants to merge 3 commits intomainfrom
vorflux/fix-broken-build

Conversation

@vorflux
Copy link
Copy Markdown
Contributor

@vorflux vorflux bot commented Apr 17, 2026

Summary

PR #45 was merged before the final three fix commits landed on the branch. Those commits were pushed after the merge, so they weren't included. This PR applies those missing fixes to main.

Changes

  1. Removed broken Build step from publish workflow -- The step ran bun run build:lib which calls esbuild lib/validate.ts, but lib/validate.ts doesn't exist in the repo (only the pre-built lib/validate.js and lib/validate.d.ts are committed). This caused every publish attempt to fail with Could not resolve "lib/validate.ts".

  2. Removed broken build:lib script from package.json -- The script referenced the non-existent lib/validate.ts file.

  3. Removed unused esbuild devDependency -- Only used by the now-removed build:lib script.

  4. Regenerated bun.lock -- Removing esbuild from devDependencies made the lockfile stale, causing bun install --frozen-lockfile to fail in CI. Regenerated the lockfile to match the updated package.json.

Testing

  • CI passes: Run #24545184973
  • Verified the workflow YAML is valid and contains all required steps (checkout, setup-node, npm upgrade, setup-bun, install, version-check, type-check, lint, publish)
  • Verified package.json retains tab indentation (Biome requirement), repository field, and all other fields
  • Verified build:lib no longer appears in workflow or package.json
  • Verified esbuild no longer appears in devDependencies

Context

See the publish workflow failure screenshot from the user -- the Build step fails with:

Error: R] Could not resolve "lib/validate.ts"

This blocks all npm publishes for this package.


Session Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant