hoist EMPTY_SET default in MemoriesGrid#856
Open
ved015 wants to merge 1 commit intosupermemoryai:mainfrom
Open
hoist EMPTY_SET default in MemoriesGrid#856ved015 wants to merge 1 commit intosupermemoryai:mainfrom
ved015 wants to merge 1 commit intosupermemoryai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hoisted the
new Set()default parameter inMemoriesGridto a module-level constant namedEMPTY_SET.Details
The
selectedDocumentIds = new Set()default parameter was causing a performance bottleneck. Because a newSetwas being instantiated on every render cycle, its reference was never stable. This invalidated theReact.memooptimization on theDocumentCardcomponents, forcing every visible card to re-render whenever the parentMemoriesGridupdated.Use
memo()for the masonry item rendering.@Dhravya please have a look