Skip to content

voltagent-bug-fixes#866

Open
sreedharsreeram wants to merge 3 commits intomainfrom
voltagent-sdk-bugfix
Open

voltagent-bug-fixes#866
sreedharsreeram wants to merge 3 commits intomainfrom
voltagent-sdk-bugfix

Conversation

@sreedharsreeram
Copy link
Copy Markdown
Contributor

No description provided.

@claude
Copy link
Copy Markdown

claude bot commented Apr 19, 2026

Claude finished @sreedharsreeram's task in 43s —— View job


Re-review Complete

  • Analyze the updated changes
  • Check if the package version was updated as requested
  • Review for bugs and security issues
  • Provide review summary

Overview: Adds verbose logging support to VoltAgent, bumps version to 2.0.0, and includes runtime warnings + JSDoc for profile mode limitations.

Changes since last review:

  • Version bumped from 1.4.4 → 2.0.0 (addresses @MaheshtheDev's request)
  • verbose option now exposed and functional (was previously hardcoded to false)

Issues found: None — this looks good to ship.

The implementation is correct:

  • The verbose parameter is properly destructured with a default value of false
  • The logger now respects the user's verbose setting
  • The version bump to 2.0.0 is appropriate since the public interface changed (adding verbose to the exported type)
  • Runtime warning correctly fires when advanced search params are set with profile mode

Score: 10/10

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 19, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 8976b99 Commit Preview URL

Branch Preview URL
Apr 20 2026, 09:03 AM

@sreedharsreeram sreedharsreeram requested review from MaheshtheDev and removed request for Dhravya April 19, 2026 23:31
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Adds a runtime warning and documentation when advanced search parameters are used with "profile" mode, where they have no effect.

Issues found: None — this looks good to ship.

The implementation is correct: the existing logic at middleware.ts:257 already ignores advanced search params when mode === "profile". This PR surfaces that behavior to developers through:

  1. A runtime warning log when the configuration mismatch is detected
  2. JSDoc notes on each affected property in the types

Score: 10/10

Comment thread packages/tools/src/voltagent/middleware.ts
Copy link
Copy Markdown
Member

@MaheshtheDev MaheshtheDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sreedharsreeram can you please update the package version to auto publish

Copy link
Copy Markdown
Contributor Author

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants