Move to FoundationEssentials#59
Merged
Merged
Conversation
Collaborator
|
Thanks for this, it looks like a good change. It looks like the Soundness checks aren't getting on with the pinned manifest though. I'm not sure at first glance if this is a shortcoming of the checks or not. |
Contributor
Author
|
@rnro Thanks! Yeah, I forgot to update the ignore files. Should be good now 👍 |
rnro
approved these changes
Mar 6, 2026
Contributor
Author
|
@rnro thanks for merging 🙌 - can we get new release tagged perhaps? |
Collaborator
simonjbeaumont
added a commit
to apple/swift-openapi-urlsession
that referenced
this pull request
Apr 8, 2026
Disables the default traits for OpenAPIRuntime, so that anyone that depends on urlsession transport, can choose disable the default. runtime traits Related: * swift-server/swift-openapi-async-http-client#59 * apple/swift-openapi-generator#878 --------- Co-authored-by: Si Beaumont <beaumont@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
FoundationEssentialsinstead ofFoundation. Also removesNIOFoundationCompat, because it did appear to be used, and that pulled in the entire Foundation.Also disabled the default traits for the
OpenAPIRuntimeto prevent linking Foundation.