Swift.org logo and link (alt 2) - #138
Open
heckj wants to merge 6 commits into
Open
Conversation
… mark The original approach targeted the Navigator sidebar's `.head-wrapper`, which swift-docc-render tears down and rebuilds once the navigator index data finishes loading, discarding whatever a script had inserted into the loading-skeleton version — so the logo never stuck around. The masthead's `.pre-title` has no such swap: it mounts once from data already known at page load, so the logo (appended there, between the sidebar toggle and the page title) stays visible regardless of the sidebar's own shown/hidden/drawer state. Also swaps the placeholder mark for the official currentColor icon from swiftlang/swift-org-website's assets/images/icon-swift.svg.
swift-docc-render hardcodes this text to the documentation.title locale string with no theme-settings.json or DocC metadata override point, so it's rewritten client-side the same way the logo is inserted.
davelester
approved these changes
Aug 10, 2026
davelester
self-requested a review
August 10, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An alternate PR to #136 with an end state that reaches into the DocC content and changes the name for the combined documentation. This is more deeply touching into DocC-Render and it's component output, effectively runtime overriding it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Screenshots of the size and dark/light mode variations: